Bug 122410 - Don't try to dispatch resize events for SVG images
Summary: Don't try to dispatch resize events for SVG images
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 122371
  Show dependency treegraph
Reported: 2013-10-06 05:02 PDT by Antti Koivisto
Modified: 2013-10-06 15:29 PDT (History)
11 users (show)

See Also:

patch (3.20 KB, patch)
2013-10-06 05:14 PDT, Antti Koivisto
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-10-06 05:02:55 PDT
SVG images have scripting disabled but we still try to dispatch resize events.
Comment 1 Antti Koivisto 2013-10-06 05:14:02 PDT
Created attachment 213509 [details]
Comment 2 Darin Adler 2013-10-06 09:32:31 PDT
Comment on attachment 213509 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=213509&action=review

r=me if you add a null check for page or explain why it's not needed

> Source/WebCore/page/FrameView.cpp:2773
> +    if (frame().page()->chrome().client().isSVGImageChromeClient())
> +        return;

What guarantees that page is non-null?
Comment 3 Antti Koivisto 2013-10-06 15:27:35 PDT
Comment 4 Antti Koivisto 2013-10-06 15:29:39 PDT
(In reply to comment #2)
> What guarantees that page is non-null?

Uh, some similar looking functions don't check it either... Added the check.