Bug 122380 - Use std::function for all policy callbacks
Summary: Use std::function for all policy callbacks
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-05 07:51 PDT by Anders Carlsson
Modified: 2013-10-05 10:06 PDT (History)
3 users (show)

See Also:

Attachments
Patch (24.84 KB, patch)
2013-10-05 07:52 PDT, Anders Carlsson 		darin: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-10-05 07:51:14 PDT 
Use std::function for all policy callbacks
Comment 1 Anders Carlsson 2013-10-05 07:52:56 PDT 
Created attachment 213451 [details]
Patch
Comment 2 Darin Adler 2013-10-05 08:31:08 PDT 
I don’t want to say review+ on this until we figure out what we’re doing about the Lion bot build failure from the first use of this technique.
Comment 3 Darin Adler 2013-10-05 09:55:21 PDT 
Comment on attachment 213451 [details]
Patch

Enjoy the "fix the Lion bot" project.
Comment 4 WebKit Commit Bot 2013-10-05 10:06:04 PDT 
Comment on attachment 213451 [details]
Patch

Rejecting attachment 213451 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 213451, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/3318221