RESOLVED WONTFIX 122373
Pass both Frame& and Document& to editing command functions. 
https://bugs.webkit.org/show_bug.cgi?id=122373
Summary Pass both Frame& and Document& to editing command functions.
Andreas Kling
Reported 2013-10-04 21:56:42 PDT
Editing commands are only executed when there is both a Frame and a Document. The code currently has to go through the Frame to the Document and all it gets is a pointer. We should be nice and pass a Document& alongside the Frame& so we don't have to suffer the ambiguity.
Attachments
Patch (51.41 KB, patch)
2013-10-04 21:57 PDT, Andreas Kling 		rniwa: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-10-04 21:57:10 PDT
Created attachment 213440 [details] Patch
Ryosuke Niwa
Comment 2 2013-10-04 21:59:43 PDT
Comment on attachment 213440 [details] Patch rs=me.
WebKit Commit Bot
Comment 3 2013-10-11 12:12:33 PDT
Comment on attachment 213440 [details] Patch Rejecting attachment 213440 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 213440, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: e: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/editing/EditorCommand.cpp Hunk #9 FAILED at 396. Hunk #12 FAILED at 463. 2 out of 28 hunks FAILED -- saving rejects to file Source/WebCore/editing/EditorCommand.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Ryosuke Niwa']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/3946205
Andreas Kling
Comment 4 2014-12-07 16:00:39 PST
Darin didn't like this, and I don't care anymore so let's just not do it.
Note You need to log in before you can comment on or make changes to this bug.