RESOLVED FIXED 122363
FTL: Optimize IsString(@2<String>) -> JSConst(true) + Phantom() 
https://bugs.webkit.org/show_bug.cgi?id=122363
Summary FTL: Optimize IsString(@2<String>) -> JSConst(true) + Phantom()
Nadav Rotem
Reported 2013-10-04 17:19:17 PDT
FTL: Optimize IsString(@2<String) -> JSConst(true) + Phantom()
Attachments
Patch (1.86 KB, patch)
2013-10-04 17:19 PDT, Nadav Rotem 		no flags
DetailsFormatted DiffDiff
Patch (1.80 KB, patch)
2013-10-04 17:35 PDT, Nadav Rotem 		no flags
DetailsFormatted DiffDiff
Patch (1.93 KB, patch)
2013-10-07 14:34 PDT, Nadav Rotem 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nadav Rotem
Comment 1 2013-10-04 17:19:52 PDT
Created attachment 213424 [details] Patch
Darin Adler
Comment 2 2013-10-04 17:28:44 PDT
Comment on attachment 213424 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213424&action=review > Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:894 > + case IsString: { > + if (node->child1().useKind() == StringUse) { > + m_insertionSet.insertNode(m_indexInBlock, SpecNone, Phantom, node->codeOrigin, > + Edge(node->child1().node(), StringUse)); > + node->convertToConstant(1); > + break; > + } > + } While I am not qualified to review this, I do have two small style comments: We should break rather than falling through at the end of this case. Also, there is no need for the outer braces around the if statement, so please remove them.
Nadav Rotem
Comment 3 2013-10-04 17:35:34 PDT
Created attachment 213426 [details] Patch
Nadav Rotem
Comment 4 2013-10-07 14:34:47 PDT
Created attachment 213617 [details] Patch
WebKit Commit Bot
Comment 5 2013-10-07 15:07:26 PDT
Comment on attachment 213617 [details] Patch Clearing flags on attachment: 213617 Committed r157059: <http://trac.webkit.org/changeset/157059>
WebKit Commit Bot
Comment 6 2013-10-07 15:07:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.