FTL: Optimize IsString(@2<String) -> JSConst(true) + Phantom()
Created attachment 213424 [details] Patch
Comment on attachment 213424 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213424&action=review > Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:894 > + case IsString: { > + if (node->child1().useKind() == StringUse) { > + m_insertionSet.insertNode(m_indexInBlock, SpecNone, Phantom, node->codeOrigin, > + Edge(node->child1().node(), StringUse)); > + node->convertToConstant(1); > + break; > + } > + } While I am not qualified to review this, I do have two small style comments: We should break rather than falling through at the end of this case. Also, there is no need for the outer braces around the if statement, so please remove them.
Created attachment 213426 [details] Patch
Created attachment 213617 [details] Patch
Comment on attachment 213617 [details] Patch Clearing flags on attachment: 213617 Committed r157059: <http://trac.webkit.org/changeset/157059>
All reviewed patches have been landed. Closing bug.