Bug 122362 - FramePolicyFunction should be an std::function
Summary: FramePolicyFunction should be an std::function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-04 17:13 PDT by Anders Carlsson
Modified: 2013-10-05 06:48 PDT (History)
7 users (show)

See Also:

Attachments
Patch (47.20 KB, patch)
2013-10-04 17:14 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (50.26 KB, patch)
2013-10-04 20:02 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (50.15 KB, patch)
2013-10-04 20:09 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (50.15 KB, patch)
2013-10-04 20:21 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (50.71 KB, patch)
2013-10-04 20:56 PDT, Anders Carlsson 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-10-04 17:13:18 PDT 
FramePolicyFunction should be an std::function
Comment 1 Anders Carlsson 2013-10-04 17:14:48 PDT 
Created attachment 213421 [details]
Patch
Comment 2 Darin Adler 2013-10-04 17:37:47 PDT 
Comment on attachment 213421 [details]
Patch

Cute how you made the functions the last argument to match the “block is last argument” style we use for the corresponding Objective-C feature. Not sure if that’s the tradition for C++ but it does seem to make the code readable.

I don’t think I’ll ever use a PTMF again!
Comment 3 EFL EWS Bot 2013-10-04 18:23:40 PDT 
Comment on attachment 213421 [details]
Patch

Attachment 213421 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/3322053
Comment 4 Build Bot 2013-10-04 18:57:21 PDT 
Comment on attachment 213421 [details]
Patch

Attachment 213421 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/3314074
Comment 5 Anders Carlsson 2013-10-04 20:02:58 PDT 
Created attachment 213434 [details]
Patch
Comment 6 Anders Carlsson 2013-10-04 20:09:49 PDT 
Created attachment 213436 [details]
Patch
Comment 7 Anders Carlsson 2013-10-04 20:21:31 PDT 
Created attachment 213437 [details]
Patch
Comment 8 Build Bot 2013-10-04 20:55:06 PDT 
Comment on attachment 213437 [details]
Patch

Attachment 213437 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/3326010
Comment 9 Anders Carlsson 2013-10-04 20:56:48 PDT 
Created attachment 213438 [details]
Patch
Comment 10 Anders Carlsson 2013-10-04 21:50:47 PDT 
Committed r156946: <http://trac.webkit.org/changeset/156946>
Comment 11 Darin Adler 2013-10-05 06:47:46 PDT 
This is causing link failures on the Mountain Lion bot, probably due to a standard library implementation problem. Various std::function-related symbols seem to be exported from WebKit2 even though we don’t want them to be.
Comment 12 Darin Adler 2013-10-05 06:48:26 PDT 
Correction: The problem is on the Lion bot.