Bug 122345 – [iOS] Upstream support for -webkit-video-playable-inline/webkit-playsinline

• Status: NEW
• Component: WebCore Misc.

[Daniel Bates]

Upstream support for CSS media query -webkit-video-playable-inline and the HTML attribute webkit-playsinline.

[Daniel Bates]

Created attachment 213396 [details]
Patch

[WebKit Commit Bot]

Attachment 213396 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/iphone-simulator/iphone/fast/media/video-inline-expected.txt', u'LayoutTests/platform/iphone-simulator/iphone/fast/media/video-inline.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/MediaFeatureNames.h', u'Source/WebCore/css/MediaQueryEvaluator.cpp', u'Source/WebCore/html/HTMLAttributeNames.in', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLMediaElement.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebPreferences.mm']" exit_code: 1
Source/WebCore/css/MediaQueryEvaluator.cpp:638:  video_playable_inlineMediaFeatureEval is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 213396 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213396&action=review

I don't see any reason for this to iOS specific.

> Source/WebCore/css/MediaFeatureNames.h:34
> +#if PLATFORM(IOS)

This should be ENABLE(...)

> Source/WebCore/css/MediaFeatureNames.h:35
> +#define IOS_VIDEO_PLAYABLE_INLINE(macro) macro(video_playable_inline, "-webkit-video-playable-inline")

This should not have an iOS prefix.