Bug 122341 - Unify rubberband control
Summary: Unify rubberband control
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-04 12:39 PDT by Sam Weinig
Modified: 2014-01-29 12:13 PST (History)
6 users (show)

See Also:

Attachments
Patch (31.47 KB, patch)
2013-10-04 15:38 PDT, Sam Weinig 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-10-04 12:39:01 PDT 
Unify rubberband control
Comment 1 Sam Weinig 2013-10-04 15:38:19 PDT 
Created attachment 213411 [details]
Patch
Comment 2 Sam Weinig 2013-10-04 16:24:28 PDT 
Committed r156924: <http://trac.webkit.org/changeset/156924>
Comment 3 Tim Horton 2014-01-29 12:13:14 PST 
Comment on attachment 213411 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213411&action=review

> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:64
> +    static bool linkedAgainstExecutableExpectingImplicitRubberBandControl = NSVersionOfLinkTimeLibrary("WebKit2") < 0x021A0200 /* 538.2.0 */;
> +    return linkedAgainstExecutableExpectingImplicitRubberBandControl;

NSVersionOfLinkTimeLibrary returns 0xffffffff for clients who don't link directly against WebKit2, like Safari. So, Safari is still getting the legacy implicit rubber-band control, while MiniBrowser is not, causing a great deal of confusion.