WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
122341
Unify rubberband control
https://bugs.webkit.org/show_bug.cgi?id=122341
Summary
Unify rubberband control
Sam Weinig
Reported
2013-10-04 12:39:01 PDT
Unify rubberband control
Attachments
Patch
(31.47 KB, patch)
2013-10-04 15:38 PDT
,
Sam Weinig
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2013-10-04 15:38:19 PDT
Created
attachment 213411
[details]
Patch
Sam Weinig
Comment 2
2013-10-04 16:24:28 PDT
Committed
r156924
: <
http://trac.webkit.org/changeset/156924
>
Tim Horton
Comment 3
2014-01-29 12:13:14 PST
Comment on
attachment 213411
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=213411&action=review
> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:64 > + static bool linkedAgainstExecutableExpectingImplicitRubberBandControl = NSVersionOfLinkTimeLibrary("WebKit2") < 0x021A0200 /* 538.2.0 */; > + return linkedAgainstExecutableExpectingImplicitRubberBandControl;
NSVersionOfLinkTimeLibrary returns 0xffffffff for clients who don't link directly against WebKit2, like Safari. So, Safari is still getting the legacy implicit rubber-band control, while MiniBrowser is not, causing a great deal of confusion.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug