Bug 122333 - Delete baseline optimizer
Summary: Delete baseline optimizer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-04 11:26 PDT by Ryosuke Niwa
Modified: 2013-11-20 16:51 PST (History)
8 users (show)

See Also:


Attachments
The baseline optimizer and its dependencies are removed. (32.53 KB, patch)
2013-11-20 08:28 PST, Berta József
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-10-04 11:26:39 PDT
At this point, we only have 4 ports that run layout tests.
We should get rid of this broken feature from webkitpy.

It only confuses hell out of me and other contributors because
the current behavior is almost a random shuffling of expected results.
Comment 1 Berta József 2013-11-20 08:28:20 PST
Created attachment 217437 [details]
The baseline optimizer and its dependencies are removed.
Comment 2 Zan Dobersek 2013-11-20 08:44:54 PST
akling was using webkit-patch optimize-baselines lately, I think with success.

Is this really good to delete? I guess it's a bit bloat-y, but presumably it still works, and is used.
Comment 3 Ryosuke Niwa 2013-11-20 16:25:02 PST
(In reply to comment #2)
> akling was using webkit-patch optimize-baselines lately, I think with success.
> 
> Is this really good to delete? I guess it's a bit bloat-y, but presumably it still works, and is used.

It's actually broken in some unknown ways :(
Comment 4 WebKit Commit Bot 2013-11-20 16:51:44 PST
Comment on attachment 217437 [details]
The baseline optimizer and its dependencies are removed.

Clearing flags on attachment: 217437

Committed r159595: <http://trac.webkit.org/changeset/159595>
Comment 5 WebKit Commit Bot 2013-11-20 16:51:46 PST
All reviewed patches have been landed.  Closing bug.