Bug 122331 - remove dpranke from webkitpy watchlist
Summary: remove dpranke from webkitpy watchlist
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-04 10:50 PDT by Dirk Pranke
Modified: 2013-10-04 11:32 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.31 KB, patch)
2013-10-04 10:50 PDT, Dirk Pranke 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2013-10-04 10:50:25 PDT 
remove dpranke from webkitpy watchlist
Comment 1 Dirk Pranke 2013-10-04 10:50:39 PDT 
Created attachment 213376 [details]
Patch
Comment 2 Dirk Pranke 2013-10-04 10:54:20 PDT 
At this point WebKit's webkitpy has diverged quite a bit from Blink's and me tracking every WebKit-side change is not all that useful.

Also, it looks like Gyuyoung landed an unreviewed change to watchlist in http://trac.webkit.org/changeset/156880 that isn't correct or even syntactically valid.

I can fix that as part of this change if people would prefer, or someone can revert that change, but I expect the EWS bots will explode on this patch with no action otherwise.
Comment 3 Brent Fulgham 2013-10-04 10:56:42 PDT 
Comment on attachment 213376 [details]
Patch

r=me.
Comment 4 WebKit Commit Bot 2013-10-04 10:56:45 PDT 
Attachment 213376 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy/common/config/watchlist']" exit_code: 1
Traceback (most recent call last):
  File "Tools/Scripts/check-webkit-style", line 48, in <module>
    sys.exit(CheckWebKitStyle().main())
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/main.py", line 154, in main
    patch_checker.check(patch)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/patchreader.py", line 83, in check
    self._text_file_reader.process_file(file_path=path, line_numbers=line_numbers)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 130, in process_file
    self._processor.process(lines, file_path, **kwargs)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checker.py", line 889, in process
    checker.check(lines)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checkers/watchlist.py", line 51, in check
    WatchListParser(log_error=log_to_style_error).parse('\n'.join(lines))
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py", line 70, in parse
    dictionary = self._eval_watch_list(watch_list_contents)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py", line 86, in _eval_watch_list
    return eval(watch_list_contents, {'__builtins__': None}, None)
  File "<string>", line 242
    "filename": r"Source/WebCore/svg, "gyuyoung.kim@webkit.org""
                                              ^
SyntaxError: invalid syntax


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Alexey Proskuryakov 2013-10-04 11:25:36 PDT 
> Also, it looks like Gyuyoung landed an unreviewed change to watchlist in http://trac.webkit.org/changeset/156880 that isn't correct or even syntactically valid.

Fixed that in r156897.
Comment 6 WebKit Commit Bot 2013-10-04 11:32:47 PDT 
Comment on attachment 213376 [details]
Patch

Clearing flags on attachment: 213376

Committed r156899: <http://trac.webkit.org/changeset/156899>
Comment 7 WebKit Commit Bot 2013-10-04 11:32:50 PDT 
All reviewed patches have been landed.  Closing bug.