Bug 122331 – remove dpranke from webkitpy watchlist

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dirk Pranke]

remove dpranke from webkitpy watchlist

[Dirk Pranke]

Created attachment 213376 [details]
Patch

[Dirk Pranke]

At this point WebKit's webkitpy has diverged quite a bit from Blink's and me tracking every WebKit-side change is not all that useful.

Also, it looks like Gyuyoung landed an unreviewed change to watchlist in http://trac.webkit.org/changeset/156880 that isn't correct or even syntactically valid.

I can fix that as part of this change if people would prefer, or someone can revert that change, but I expect the EWS bots will explode on this patch with no action otherwise.

[Brent Fulgham]

Comment on attachment 213376 [details]
Patch

r=me.

[WebKit Commit Bot]

Attachment 213376 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy/common/config/watchlist']" exit_code: 1
Traceback (most recent call last):
  File "Tools/Scripts/check-webkit-style", line 48, in <module>
    sys.exit(CheckWebKitStyle().main())
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/main.py", line 154, in main
    patch_checker.check(patch)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/patchreader.py", line 83, in check
    self._text_file_reader.process_file(file_path=path, line_numbers=line_numbers)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 130, in process_file
    self._processor.process(lines, file_path, **kwargs)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checker.py", line 889, in process
    checker.check(lines)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/checkers/watchlist.py", line 51, in check
    WatchListParser(log_error=log_to_style_error).parse('\n'.join(lines))
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py", line 70, in parse
    dictionary = self._eval_watch_list(watch_list_contents)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py", line 86, in _eval_watch_list
    return eval(watch_list_contents, {'__builtins__': None}, None)
  File "<string>", line 242
    "filename": r"Source/WebCore/svg, "[e-mail]""
                                              ^
SyntaxError: invalid syntax


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alexey Proskuryakov]

> Also, it looks like Gyuyoung landed an unreviewed change to watchlist in http://trac.webkit.org/changeset/156880 that isn't correct or even syntactically valid.

Fixed that in r156897.

[WebKit Commit Bot]

Comment on attachment 213376 [details]
Patch

Clearing flags on attachment: 213376

Committed r156899: <http://trac.webkit.org/changeset/156899>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.