Bug 122325 - Remove WTF smart pointers 'const_pointer_cast'
Summary: Remove WTF smart pointers 'const_pointer_cast'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-04 07:18 PDT by Mikhail Pozdnyakov
Modified: 2013-10-04 17:24 PDT (History)
4 users (show)

See Also:

Attachments
patch (2.97 KB, patch)
2013-10-04 07:22 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2013-10-04 07:18:00 PDT 
WTF smart pointers 'const_pointer_cast' functions are not used by anyone.
Another reason is that const_pointer_cast functions are implemented wrongly (try to cast to a different pointer type).
Comment 1 Mikhail Pozdnyakov 2013-10-04 07:22:08 PDT 
Created attachment 213363 [details]
patch
Comment 2 Darin Adler 2013-10-04 17:01:14 PDT 
Comment on attachment 213363 [details]
patch

Seems OK. People aren’t using RefPtr<const X> anyway, and PassOwnPtr is on the way out.
Comment 3 WebKit Commit Bot 2013-10-04 17:24:49 PDT 
Comment on attachment 213363 [details]
patch

Clearing flags on attachment: 213363

Committed r156931: <http://trac.webkit.org/changeset/156931>
Comment 4 WebKit Commit Bot 2013-10-04 17:24:51 PDT 
All reviewed patches have been landed.  Closing bug.