Bug 122322 - MediaStreamTrack can't be FINAL
Summary: MediaStreamTrack can't be FINAL
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 79203
  Show dependency treegraph
Reported: 2013-10-04 02:26 PDT by Philippe Normand
Modified: 2013-10-07 05:26 PDT (History)
2 users (show)

See Also:

patch (3.29 KB, patch)
2013-10-04 02:29 PDT, Philippe Normand
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2013-10-04 02:26:54 PDT
Because AudioStreamTrack and VideoStreamTrack inherit from it.
Comment 1 Philippe Normand 2013-10-04 02:29:58 PDT
Created attachment 213343 [details]
Comment 2 Alexey Proskuryakov 2013-10-04 10:20:18 PDT
Comment on attachment 213343 [details]

Are there any methods in these classes that can be final?
Comment 3 Darin Adler 2013-10-04 17:43:34 PDT
Comment on attachment 213343 [details]

How did this even compile?

Can any of the virtual functions in MediaStreamTrack be FINAL? If the entire class isn’t FINAL, it then becomes helpful to mark the functions themselves FINAL if there is no need to override them.

r=me but I suggest adding some FINAL to any functions we don’t need to override.
Comment 4 Eric Carlson 2013-10-06 20:47:15 PDT
I have a fix for this in the massive patch attached to https://bugs.webkit.org/show_bug.cgi?id=121940 if you want to let me take care of this.
Comment 5 Philippe Normand 2013-10-07 00:06:00 PDT
I was thinking of landing this patch with the updates Darin and Alexey suggested.

(In reply to comment #3)
> (From update of attachment 213343 [details])
> How did this even compile?

It didn't :) Currently no port enables mediastream in their default build. Last week I started working on the GStreamer mediastream backend some other folks started some months ago. One part is in Bug 110150 but I haven't yet uploaded the version that actually builds.
Comment 6 Philippe Normand 2013-10-07 00:28:31 PDT
Committed r157030: <http://trac.webkit.org/changeset/157030>