Bug 122305 – [GTK] Enable text edition UndoOperations support in WebKit2

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Lorenzo Tilve]

The methods that interact with the text edition to provide support for undo/redo operations are not implemented, when they could be using the operations that DefaultUndoController provides.

As a consequence of this, the functionality and the layout tests related with these type of operations are failing.

[Lorenzo Tilve]

Created attachment 213314 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Martin Robinson]

Comment on attachment 213314 [details]
Patch

Surely this changes layout tests results? Can we unskip some tests with this patch?

[Sergio Villar Senin]

(In reply to comment #3)
> (From update of attachment 213314 [details])
> Surely this changes layout tests results? Can we unskip some tests with this patch?

The patch already removes tons of undo tests from the wk2 testexpectations file

[Carlos Garcia Campos]

Comment on attachment 213314 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213314&action=review

Looks good to me in general, I have just a few minor comments. Thanks!

> Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:31
> +#include "DefaultUndoController.h"

This is already included in PageClientImpl.h

> Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h:41
> +class DefaultUndoController;

Do we really need this? We are already including the header here.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:375
> -    priv->pageClient = PageClientImpl::create(viewWidget);
> +    priv->pageClient = PageClientImpl::create(viewWidget, &priv->undoController);

Wouldn't it be simpler to make DefaultUndoController a member of PageClientImpl? The undocontroller is not used by the WebKitWebViewBase at all

[Lorenzo Tilve]

Created attachment 213368 [details]
Patch

Applied the suggested corrections

[Carlos Garcia Campos]

Comment on attachment 213368 [details]
Patch

Looks great, thanks!

[Martin Robinson]

(In reply to comment #3)
> (From update of attachment 213314 [details])
> Surely this changes layout tests results? Can we unskip some tests with this patch?

Whoops. Sorry about that. I missed that portion of the patch.

[WebKit Commit Bot]

Comment on attachment 213368 [details]
Patch

Clearing flags on attachment: 213368

Committed r156892: <http://trac.webkit.org/changeset/156892>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.