Bug 122299 - [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
Summary: [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommand...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-03 14:05 PDT by Tim Horton
Modified: 2013-10-04 11:38 PDT (History)
3 users (show)

See Also:

Attachments
patch (5.92 KB, patch)
2013-10-03 14:16 PDT, Tim Horton 		bdakin: review+
Details | Formatted Diff | Diff
new patch, turn off threaded scrolling everywhere (5.98 KB, patch)
2013-10-04 11:24 PDT, Tim Horton 		bdakin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-10-03 14:05:03 PDT 
http://trac.webkit.org/changeset/156793 means that threaded scrolling is enabled by default for the WebKit2 API tests. This happened to break three tests.

I’ve fixed the two relatively straightforward tests by using our synchronously-wait-for-the-scrolling-thread-to-tell-the-main-thread-the-new-position code that happens to be a part of the force repaint logic (unfortunately).

I’ve fixed one other where that wasn’t working correctly by disabling threaded scrolling for that test.
Comment 1 Tim Horton 2013-10-03 14:16:15 PDT 
Created attachment 213295 [details]
patch
Comment 2 Tim Horton 2013-10-03 16:11:03 PDT 
http://trac.webkit.org/changeset/156864
Comment 3 Tim Horton 2013-10-04 11:22:27 PDT 
This is still happening flakily; I’ll just turn off threaded scrolling for all three tests.
Comment 4 Tim Horton 2013-10-04 11:24:35 PDT 
Created attachment 213379 [details]
new patch, turn off threaded scrolling everywhere
Comment 5 Tim Horton 2013-10-04 11:38:21 PDT 
http://trac.webkit.org/changeset/156898