RESOLVED WONTFIX122298
Allow misspelling dots to overhang their constituent text by a single pixel 
https://bugs.webkit.org/show_bug.cgi?id=122298
Summary Allow misspelling dots to overhang their constituent text by a single pixel
Myles C. Maxfield
Reported 2013-10-03 13:23:19 PDT
Allow misspelling dots to overhang their constituent text by a single pixel
Attachments
Patch (2.47 KB, patch)
2013-10-03 13:24 PDT, Myles C. Maxfield 		sam: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2013-10-03 13:24:28 PDT
Created attachment 213289 [details] Patch
Myles C. Maxfield
Comment 2 2013-10-03 13:25:02 PDT
I don't want to rebaseline pixel tests until https://bugs.webkit.org/show_bug.cgi?id=122146 is taken care of
Myles C. Maxfield
Comment 3 2013-10-03 13:32:06 PDT
<rdar://problem/15144058>
Sam Weinig
Comment 4 2013-10-03 23:13:46 PDT
Why do we want to do this? Does it make something better?
Myles C. Maxfield
Comment 5 2013-10-04 10:46:28 PDT
I'd say it does. Take a look at the screenshots. IMO the extra dot makes it look much better.
Sam Weinig
Comment 6 2013-10-04 10:59:01 PDT
Comment on attachment 213289 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213289&action=review How does this nudge work for other font sizes / fonts / glyphs in fonts. This also needs tests. > Source/WebCore/platform/graphics/mac/GraphicsContextMac.mm:165 > + width = ceil(width/patternWidth)*patternWidth; Please put spaces around the / and *.
Sam Weinig
Comment 7 2013-10-04 10:59:47 PDT
(In reply to comment #5) > I'd say it does. Take a look at the screenshots. IMO the extra dot makes it look much better. There are no screenshots attached to the bugzilla. You are probably referring to the radar, but please remember that not everyone has access to radar.
Myles C. Maxfield
Comment 8 2013-10-04 11:27:23 PDT
Comment on attachment 213289 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213289&action=review >> Source/WebCore/platform/graphics/mac/GraphicsContextMac.mm:165 >> + width = ceil(width/patternWidth)*patternWidth; > > Please put spaces around the / and *. Done.
Note You need to log in before you can comment on or make changes to this bug.