Bug 122279 - [WebIDL] Annotate IDL interfaces under Source/WebCore/svg/ with the OperationsNotDeletable attribute
Summary: [WebIDL] Annotate IDL interfaces under Source/WebCore/svg/ with the Operation...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks: 122213
  Show dependency treegraph
 
Reported: 2013-10-03 09:05 PDT by Zan Dobersek
Modified: 2013-10-06 11:09 PDT (History)
8 users (show)

See Also:


Attachments
Patch (82.21 KB, patch)
2013-10-03 09:11 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch (15.02 KB, patch)
2013-10-04 00:00 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch (17.75 KB, patch)
2013-10-04 03:26 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-10-03 09:05:12 PDT
[WebIDL] Annotate IDL interfaces under Source/WebCore/svg/ with the OperationsNotDeletable attribute
Comment 1 Zan Dobersek 2013-10-03 09:11:58 PDT
Created attachment 213264 [details]
Patch
Comment 2 Zan Dobersek 2013-10-03 14:27:13 PDT
Comment on attachment 213264 [details]
Patch

I'll recheck the changes to remove unnecessary annotations on interfaces with no operations.
Comment 3 Zan Dobersek 2013-10-04 00:00:39 PDT
Created attachment 213338 [details]
Patch
Comment 4 Zan Dobersek 2013-10-04 03:26:58 PDT
Created attachment 213351 [details]
Patch
Comment 5 Zan Dobersek 2013-10-04 03:27:36 PDT
Comment on attachment 213351 [details]
Patch

Had to add the attribute to one exception interface and three more interfaces that don't declare any operations but implement different interfaces that do declare operations.
Comment 6 Darin Adler 2013-10-05 07:31:27 PDT
Comment on attachment 213351 [details]
Patch

I am not sure I understand the comment about needing to add this to interfaces that don't declare any operations but implement different interfaces that do declare operations. But I’ll take your word from it that it’s helpful. Just remember that we have to remove all of these so any we don’t add now is one less thing to come back to later.
Comment 7 Zan Dobersek 2013-10-06 11:01:08 PDT
The 'A implements B' statement requires all the objects implementing the interface A to also implement the interface B. The bindings generator does not propagate the interface attributes on the interface B to the interface A, so the OperationsNotDeletable attribute was added to the few interfaces that don't declare any operations but implement other interfaces that do.
Comment 8 Zan Dobersek 2013-10-06 11:09:21 PDT
Comment on attachment 213351 [details]
Patch

Clearing flags on attachment: 213351

Committed r156997: <http://trac.webkit.org/changeset/156997>
Comment 9 Zan Dobersek 2013-10-06 11:09:29 PDT
All reviewed patches have been landed.  Closing bug.