Bug 122275 - [WebIDL] Annotate IDL interfaces under Source/WebCore/fileapi/ with the OperationsNotDeletable attribute
Summary: [WebIDL] Annotate IDL interfaces under Source/WebCore/fileapi/ with the Opera...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks: 122213
  Show dependency tree / graph
 
Reported: 2013-10-03 08:57 PDT by Zan Dobersek
Modified: 2013-10-04 13:32 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.97 KB, patch)
2013-10-03 08:57 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch for landing (4.33 KB, patch)
2013-10-04 03:18 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-10-03 08:57:26 PDT 
[WebIDL] Annotate IDL interfaces under Source/WebCore/fileapi/ with the OperationsNotDeletable attribute
Comment 1 Zan Dobersek 2013-10-03 08:57:58 PDT 
Created attachment 213258 [details]
Patch
Comment 2 Darin Adler 2013-10-03 12:55:32 PDT 
Comment on attachment 213258 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213258&action=review

> Source/WebCore/fileapi/File.idl:30
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/fileapi/FileError.idl:35
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.
Comment 3 Zan Dobersek 2013-10-04 03:18:34 PDT 
Created attachment 213350 [details]
Patch for landing

Had to add the attribute to one more exception interface.
Comment 4 Zan Dobersek 2013-10-04 13:32:15 PDT 
Comment on attachment 213350 [details]
Patch for landing

Clearing flags on attachment: 213350

Committed r156909: <http://trac.webkit.org/changeset/156909>
Comment 5 Zan Dobersek 2013-10-04 13:32:22 PDT 
All reviewed patches have been landed.  Closing bug.