Bug 122271 - [WebIDL] Annotate IDL interfaces under Source/WebCore/dom/ with the OperationsNotDeletable attribute
Summary: [WebIDL] Annotate IDL interfaces under Source/WebCore/dom/ with the Operation...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks: 122213
  Show dependency treegraph
 
Reported: 2013-10-03 08:49 PDT by Zan Dobersek
Modified: 2013-10-04 13:30 PDT (History)
7 users (show)

See Also:


Attachments
Patch (38.99 KB, patch)
2013-10-03 08:52 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch for landing (26.86 KB, patch)
2013-10-04 03:13 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-10-03 08:49:47 PDT
[WebIDL] Annotate IDL interfaces under Source/WebCore/dom/ with the OperationsNotDeletable attribute
Comment 1 Zan Dobersek 2013-10-03 08:52:02 PDT
Created attachment 213254 [details]
Patch
Comment 2 Darin Adler 2013-10-03 12:54:02 PDT
Comment on attachment 213254 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213254&action=review

> Source/WebCore/dom/Attr.idl:24
> +    OperationsNotDeletable

No operations in this class, so it would be good not to make this change.

> Source/WebCore/dom/BeforeLoadEvent.idl:29
> +    OperationsNotDeletable

No operations in this class, so it would be good not to make this change.

> Source/WebCore/dom/BeforeUnloadEvent.idl:28
> +    OperationsNotDeletable

No operations in this class, so it would be good not to make this change.

> Source/WebCore/dom/CDATASection.idl:21
> +    OperationsNotDeletable

No operations in this class, so it would be good not to make this change.

> Source/WebCore/dom/ClientRect.idl:29
> +    OperationsNotDeletable

No operations in this class, so it would be good not to make this change.

> Source/WebCore/dom/Comment.idl:21
> +    OperationsNotDeletable

No operations in this class, so it would be good not to make this change.

> Source/WebCore/dom/CustomElementConstructor.idl:29
> +    OperationsNotDeletable

No operations in this class, so it would be good not to make this change.

> Source/WebCore/dom/DOMError.idl:31
> +    OperationsNotDeletable

No operations in this class, so it would be good not to make this change.

> Source/WebCore/dom/DocumentType.idl:22
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/Entity.idl:21
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/EntityReference.idl:21
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/ErrorEvent.idl:34
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/FocusEvent.idl:29
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/MessageChannel.idl:35
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/MutationRecord.idl:33
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/Notation.idl:21
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/PageTransitionEvent.idl:28
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/PopStateEvent.idl:30
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/ProcessingInstruction.idl:23
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/ProgressEvent.idl:29
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/SecurityPolicyViolationEvent.idl:28
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/Touch.idl:29
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/TransitionEvent.idl:29
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/WebKitAnimationEvent.idl:28
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.

> Source/WebCore/dom/WebKitTransitionEvent.idl:28
> +    OperationsNotDeletable

No operations in this interface, so it would be good not to make this change.
Comment 3 Zan Dobersek 2013-10-04 03:13:17 PDT
Created attachment 213349 [details]
Patch for landing

Had to add the attribute to three exception interfaces declaring the toString operation and one more interface that implements an operation-declaring interface.
Comment 4 Zan Dobersek 2013-10-04 13:29:52 PDT
Comment on attachment 213349 [details]
Patch for landing

Clearing flags on attachment: 213349

Committed r156908: <http://trac.webkit.org/changeset/156908>
Comment 5 Zan Dobersek 2013-10-04 13:30:00 PDT
All reviewed patches have been landed.  Closing bug.