Bug 122267 – [EFL] [DEBUG] JavaScriptCore fails to build

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Rob Płóciennik]

Build fails due to an expression containing comparison between signed and unsigned integer.

Source/JavaScriptCore/llint/LLIntData.cpp: In static member function ‘static void JSC::LLInt::Data::performAssertions(JSC::VM&)’:
Source/JavaScriptCore/llint/LLIntData.cpp:128:5: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]

[Sergio Correia (qrwteyrutiyoup)]

Created attachment 213244 [details]
Patch

[Rob Płóciennik]

How about changing it to:

ASSERT(MarkedBlock::blockMask == ~static_cast<decltype(MarkedBlock::blockMask)>(0xffff));

[Sergio Correia (qrwteyrutiyoup)]

(In reply to comment #2)
> How about changing it to:
> 
> ASSERT(MarkedBlock::blockMask == ~static_cast<decltype(MarkedBlock::blockMask)>(0xffff));

Nice suggestion. I am going to update the patch.

[Sergio Correia (qrwteyrutiyoup)]

(In reply to comment #3)
> (In reply to comment #2)
> > How about changing it to:
> > 
> > ASSERT(MarkedBlock::blockMask == ~static_cast<decltype(MarkedBlock::blockMask)>(0xffff));
> 
> Nice suggestion. I am going to update the patch.

Michael, I saw you have just r+'ed it; should I update the patch to apply Rob's suggestion?

[Michael Saboff]

(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > How about changing it to:
> > > 
> > > ASSERT(MarkedBlock::blockMask == ~static_cast<decltype(MarkedBlock::blockMask)>(0xffff));
> > 
> > Nice suggestion. I am going to update the patch.
> 
> Michael, I saw you have just r+'ed it; should I update the patch to apply Rob's suggestion?

Sure.  I just CQ-.  Maybe that stopped the bots.

[Sergio Correia (qrwteyrutiyoup)]

Created attachment 213271 [details]
Patch

Updated as per Rob's suggestion.

[WebKit Commit Bot]

Comment on attachment 213271 [details]
Patch

Clearing flags on attachment: 213271

Committed r156837: <http://trac.webkit.org/changeset/156837>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.