Bug 122256 - Move setting of some layout bits to RenderElement
Summary: Move setting of some layout bits to RenderElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 122259
Blocks:
  Show dependency tree / graph
 
Reported: 2013-10-02 19:00 PDT by Antti Koivisto
Modified: 2013-10-03 21:03 PDT (History)
4 users (show)

See Also:

Attachments
patch (92.33 KB, patch)
2013-10-02 19:13 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
slightly better patch (92.20 KB, patch)
2013-10-02 19:17 PDT, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
fix an accidental change (91.60 KB, patch)
2013-10-03 19:52 PDT, Antti Koivisto 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (463.55 KB, application/zip)
2013-10-03 20:52 PDT, Build Bot 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-10-02 19:00:34 PDT 
They don't apply to text nodes.
Comment 1 Antti Koivisto 2013-10-02 19:13:37 PDT 
Created attachment 213222 [details]
patch
Comment 2 Antti Koivisto 2013-10-02 19:17:36 PDT 
Created attachment 213223 [details]
slightly better patch
Comment 3 Antti Koivisto 2013-10-02 19:25:52 PDT 
https://trac.webkit.org/r156816
Comment 4 Ryosuke Niwa 2013-10-02 22:02:53 PDT 
It looks like this patch caused 8 tests to fail:
http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r156817%20(13451)/results.html
Comment 5 WebKit Commit Bot 2013-10-02 22:51:48 PDT 
Re-opened since this is blocked by bug 122259
Comment 6 Antti Koivisto 2013-10-03 19:52:02 PDT 
Created attachment 213325 [details]
fix an accidental change
Comment 7 Build Bot 2013-10-03 20:52:43 PDT 
Comment on attachment 213325 [details]
fix an accidental change

Attachment 213325 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/2976034

New failing tests:
compositing/repaint/positioned-movement.html
Comment 8 Build Bot 2013-10-03 20:52:45 PDT 
Created attachment 213327 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 9 Antti Koivisto 2013-10-03 21:03:53 PDT 
https://trac.webkit.org/r156876  (with the test fixed)