RESOLVED FIXED 122256
Move setting of some layout bits to RenderElement 
https://bugs.webkit.org/show_bug.cgi?id=122256
Summary Move setting of some layout bits to RenderElement
Antti Koivisto
Reported 2013-10-02 19:00:34 PDT
They don't apply to text nodes.
Attachments
patch (92.33 KB, patch)
2013-10-02 19:13 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
slightly better patch (92.20 KB, patch)
2013-10-02 19:17 PDT, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
fix an accidental change (91.60 KB, patch)
2013-10-03 19:52 PDT, Antti Koivisto 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (463.55 KB, application/zip)
2013-10-03 20:52 PDT, Build Bot 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-10-02 19:13:37 PDT
Created attachment 213222 [details] patch
Antti Koivisto
Comment 2 2013-10-02 19:17:36 PDT
Created attachment 213223 [details] slightly better patch
Antti Koivisto
Comment 3 2013-10-02 19:25:52 PDT
https://trac.webkit.org/r156816
Ryosuke Niwa
Comment 4 2013-10-02 22:02:53 PDT
It looks like this patch caused 8 tests to fail: http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r156817%20(13451)/results.html
WebKit Commit Bot
Comment 5 2013-10-02 22:51:48 PDT
Re-opened since this is blocked by bug 122259
Antti Koivisto
Comment 6 2013-10-03 19:52:02 PDT
Created attachment 213325 [details] fix an accidental change
Build Bot
Comment 7 2013-10-03 20:52:43 PDT
Comment on attachment 213325 [details] fix an accidental change Attachment 213325 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/2976034 New failing tests: compositing/repaint/positioned-movement.html
Build Bot
Comment 8 2013-10-03 20:52:45 PDT
Created attachment 213327 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Antti Koivisto
Comment 9 2013-10-03 21:03:53 PDT
https://trac.webkit.org/r156876 (with the test fixed)
Note You need to log in before you can comment on or make changes to this bug.