Bug 122252 - AX: Facebook wrapped a file upload button in an unfocusable ARIA button, which doesn't work with AXPress.
Summary: AX: Facebook wrapped a file upload button in an unfocusable ARIA button, whic...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-10-02 18:01 PDT by James Craig
Modified: 2013-10-07 08:08 PDT (History)
9 users (show)

See Also:

Attachments
test case demonstrating bug (849 bytes, text/html)
2013-10-02 18:03 PDT, James Craig 		no flags Details
patch (6.58 KB, patch)
2013-10-04 14:55 PDT, chris fleizach 		no flags Details | Formatted Diff | Diff
patch (6.56 KB, patch)
2013-10-04 16:18 PDT, chris fleizach 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Craig 2013-10-02 18:01:20 PDT 
AX: Facebook wrapped a file upload button in an unfocusable ARIA button, which doesn't work with AXPress.

It's dumb that Facebook does this, but we should probably still work around it in WebKit. If a File upload button is included in a custom ARIA button, either have WebKit ignore the ARIA button (just expose the native field to the AX API), or have WebKit expose the contents of the button (usually buttons children are presentational), or have AXPress on the ARIA button traverse down the DOM tree to the native element. I don't have a preference for one solution or the other.
Comment 1 James Craig 2013-10-02 18:01:31 PDT 
<rdar://problem/15132298>
Comment 2 James Craig 2013-10-02 18:03:11 PDT 
Created attachment 213219 [details]
test case demonstrating bug
Comment 3 chris fleizach 2013-10-04 14:55:51 PDT 
Created attachment 213406 [details]
patch
Comment 4 WebKit Commit Bot 2013-10-04 15:00:32 PDT 
Attachment 213406 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/accessibility/axpress-on-aria-button-expected.txt', u'LayoutTests/accessibility/axpress-on-aria-button.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AccessibilityNodeObject.cpp']" exit_code: 1
Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1001:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 chris fleizach 2013-10-04 16:18:41 PDT 
Created attachment 213415 [details]
patch
Comment 6 WebKit Commit Bot 2013-10-07 08:08:48 PDT 
Comment on attachment 213415 [details]
patch

Clearing flags on attachment: 213415

Committed r157038: <http://trac.webkit.org/changeset/157038>
Comment 7 WebKit Commit Bot 2013-10-07 08:08:51 PDT 
All reviewed patches have been landed.  Closing bug.