Bug 122252 – AX: Facebook wrapped a file upload button in an unfocusable ARIA button, which doesn't work with AXPress.

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[James Craig]

AX: Facebook wrapped a file upload button in an unfocusable ARIA button, which doesn't work with AXPress.

It's dumb that Facebook does this, but we should probably still work around it in WebKit. If a File upload button is included in a custom ARIA button, either have WebKit ignore the ARIA button (just expose the native field to the AX API), or have WebKit expose the contents of the button (usually buttons children are presentational), or have AXPress on the ARIA button traverse down the DOM tree to the native element. I don't have a preference for one solution or the other.

[James Craig]

<rdar://problem/15132298>

[James Craig]

Created attachment 213219 [details]
test case demonstrating bug

[chris fleizach]

Created attachment 213406 [details]
patch

[WebKit Commit Bot]

Attachment 213406 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/accessibility/axpress-on-aria-button-expected.txt', u'LayoutTests/accessibility/axpress-on-aria-button.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AccessibilityNodeObject.cpp']" exit_code: 1
Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1001:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[chris fleizach]

Created attachment 213415 [details]
patch

[WebKit Commit Bot]

Comment on attachment 213415 [details]
patch

Clearing flags on attachment: 213415

Committed r157038: <http://trac.webkit.org/changeset/157038>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.