Bug 122243 - [css-shapes] shape-outside does not properly handle the container and the float having different writing modes
Summary: [css-shapes] shape-outside does not properly handle the container and the flo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bem Jones-Bey
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-02 15:22 PDT by Bem Jones-Bey
Modified: 2013-10-02 16:25 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.67 KB, patch)
2013-10-02 15:28 PDT, Bem Jones-Bey
no flags Details | Formatted Diff | Diff
Patch (6.06 KB, patch)
2013-10-02 15:53 PDT, Bem Jones-Bey
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bem Jones-Bey 2013-10-02 15:22:03 PDT
[css-shapes] shape-outside does not properly handle the container and the float having different writing modes
Comment 1 Bem Jones-Bey 2013-10-02 15:28:30 PDT
Created attachment 213207 [details]
Patch

Use the proper writing mode when computing margins and widths.
Comment 2 Alexandru Chiculita 2013-10-02 15:36:40 PDT
Comment on attachment 213207 [details]
Patch

r=me
Comment 3 Zoltan Horvath 2013-10-02 15:40:25 PDT
Comment on attachment 213207 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213207&action=review

3 small comments below, otherwise looks good to me.


> Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp:70
> +                m_leftMarginBoxDelta = segments[0].logicalLeft + containingBlock->marginStartForChild(m_renderer);

We should use segments.first().logicalLeft here.

> Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp:71
> +                m_rightMarginBoxDelta = segments[segments.size()-1].logicalRight - containingBlock->logicalWidthForChild(m_renderer) - containingBlock->marginEndForChild(m_renderer);

We should use segments.last().logicalRight here.

> LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-different-writing-modes-expected.html:22
> +</body>

I would put a link to the bug # and the title.
Comment 4 Bem Jones-Bey 2013-10-02 15:53:56 PDT
Created attachment 213209 [details]
Patch

Update for comments
Comment 5 WebKit Commit Bot 2013-10-02 16:25:57 PDT
Comment on attachment 213209 [details]
Patch

Clearing flags on attachment: 213209

Committed r156806: <http://trac.webkit.org/changeset/156806>
Comment 6 WebKit Commit Bot 2013-10-02 16:25:59 PDT
All reviewed patches have been landed.  Closing bug.