[css-shapes] shape-outside does not properly handle the container and the float having different writing modes
Created attachment 213207 [details] Patch Use the proper writing mode when computing margins and widths.
Comment on attachment 213207 [details] Patch r=me
Comment on attachment 213207 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213207&action=review 3 small comments below, otherwise looks good to me. > Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp:70 > + m_leftMarginBoxDelta = segments[0].logicalLeft + containingBlock->marginStartForChild(m_renderer); We should use segments.first().logicalLeft here. > Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp:71 > + m_rightMarginBoxDelta = segments[segments.size()-1].logicalRight - containingBlock->logicalWidthForChild(m_renderer) - containingBlock->marginEndForChild(m_renderer); We should use segments.last().logicalRight here. > LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-different-writing-modes-expected.html:22 > +</body> I would put a link to the bug # and the title.
Created attachment 213209 [details] Patch Update for comments
Comment on attachment 213209 [details] Patch Clearing flags on attachment: 213209 Committed r156806: <http://trac.webkit.org/changeset/156806>
All reviewed patches have been landed. Closing bug.