Bug 122232 - http://build.webkit.org/dashboard doesn't report failures for bindings tests, possibly more
Summary: http://build.webkit.org/dashboard doesn't report failures for bindings tests,...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks: 122283
  Show dependency tree / graph
 
Reported: 2013-10-02 13:22 PDT by Alexey Proskuryakov
Modified: 2013-10-07 11:51 PDT (History)
2 users (show)

See Also:

Attachments
Patch (8.95 KB, patch)
2013-10-02 15:04 PDT, Timothy Hatcher 		ap: review+
ap: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-10-02 13:22:46 PDT 
This build is red because of bindings-generation-tests, but dashboard says that it's green: <http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK1%20%28Tests%29/builds/10527>.

Long term direction is that we should unify most types of tests and have all issues reported by one script, but we are nowhere near that.
Comment 1 Timothy Hatcher 2013-10-02 15:04:35 PDT 
Created attachment 213204 [details]
Patch
Comment 2 Alexey Proskuryakov 2013-10-02 15:14:54 PDT 
Comment on attachment 213204 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213204&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:70
> +                var bindingTestResults = iteration.bindingTestResults || {failureCount: 0};

Hmm, shouldn't this be {errorOccurred: false}?
Comment 3 Timothy Hatcher 2013-10-04 22:29:06 PDT 
Comment on attachment 213204 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213204&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:70
>> +                var bindingTestResults = iteration.bindingTestResults || {failureCount: 0};
> 
> Hmm, shouldn't this be {errorOccurred: false}?

No, this makes sure failureCount is 0 when adding totalFailures. Otherwise undefined causes a NaN total.
Comment 4 Alexey Proskuryakov 2013-10-04 22:37:14 PDT 
Comment on attachment 213204 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213204&action=review

>>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:70
>>> +                var bindingTestResults = iteration.bindingTestResults || {failureCount: 0};
>> 
>> Hmm, shouldn't this be {errorOccurred: false}?
> 
> No, this makes sure failureCount is 0 when adding totalFailures. Otherwise undefined causes a NaN total.

totalFailures uses errorOccurred:

 88                    var totalFailures = layoutTestResults.failureCount + javascriptTestResults.failureCount + pythonTestResults.failureCount + perlTestResults.failureCount + bindingTestResults.errorOccurred;
Comment 5 Timothy Hatcher 2013-10-04 22:41:51 PDT 
Comment on attachment 213204 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213204&action=review

>>>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:70
>>>> +                var bindingTestResults = iteration.bindingTestResults || {failureCount: 0};
>>> 
>>> Hmm, shouldn't this be {errorOccurred: false}?
>> 
>> No, this makes sure failureCount is 0 when adding totalFailures. Otherwise undefined causes a NaN total.
> 
> totalFailures uses errorOccurred:
> 
>  88                    var totalFailures = layoutTestResults.failureCount + javascriptTestResults.failureCount + pythonTestResults.failureCount + perlTestResults.failureCount + bindingTestResults.errorOccurred;

Ah, yep! Fill fix. Good catch.
Comment 6 Timothy Hatcher 2013-10-07 11:51:07 PDT 
http://trac.webkit.org/changeset/157052