RESOLVED FIXED 122204
Add *CSS* prefix to FontFeatureValue to generate toCSSFontFeatureValue(), and use it 
https://bugs.webkit.org/show_bug.cgi?id=122204
Summary Add *CSS* prefix to FontFeatureValue to generate toCSSFontFeatureValue(), and...
Gyuyoung Kim
Reported 2013-10-01 22:41:53 PDT
We need to add *CSS* prefix to FontFeatureValue in order to generate toCSSFontFeatureValue().
Attachments
Patch (30.29 KB, patch)
2013-10-01 22:48 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch for landing (27.57 KB, patch)
2013-10-05 20:47 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch for landing (28.01 KB, patch)
2013-10-05 20:54 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch for landing (29.48 KB, patch)
2013-10-05 23:16 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2013-10-01 22:48:26 PDT
Created attachment 213152 [details] Patch
Gyuyoung Kim
Comment 2 2013-10-05 06:57:22 PDT
CC'ing Darin.
WebKit Commit Bot
Comment 3 2013-10-05 10:06:05 PDT
Comment on attachment 213152 [details] Patch Rejecting attachment 213152 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 213152, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: /git.webkit.org/WebKit 29f4330..775dbb9 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 156960 = 29f43307b06bd4c2f18cd3842c4603cda325421d r156961 = 775dbb91e139507d9a946048ecd54b08ba9c94cc Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.appspot.com/results/3318222
Gyuyoung Kim
Comment 4 2013-10-05 20:47:21 PDT
Created attachment 213488 [details] Patch for landing
Build Bot
Comment 5 2013-10-05 20:51:06 PDT
Comment on attachment 213488 [details] Patch for landing Attachment 213488 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/3478023
EFL EWS Bot
Comment 6 2013-10-05 20:51:58 PDT
Comment on attachment 213488 [details] Patch for landing Attachment 213488 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/3478025
EFL EWS Bot
Comment 7 2013-10-05 20:53:31 PDT
Comment on attachment 213488 [details] Patch for landing Attachment 213488 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/3475029
Gyuyoung Kim
Comment 8 2013-10-05 20:54:32 PDT
Created attachment 213489 [details] Patch for landing
EFL EWS Bot
Comment 9 2013-10-05 21:08:29 PDT
Comment on attachment 213489 [details] Patch for landing Attachment 213489 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/3471036
Build Bot
Comment 10 2013-10-05 21:17:09 PDT
Comment on attachment 213489 [details] Patch for landing Attachment 213489 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3475033
EFL EWS Bot
Comment 11 2013-10-05 21:24:23 PDT
Comment on attachment 213489 [details] Patch for landing Attachment 213489 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/3478034
Build Bot
Comment 12 2013-10-05 21:36:52 PDT
Comment on attachment 213489 [details] Patch for landing Attachment 213489 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/3477047
Gyuyoung Kim
Comment 13 2013-10-05 23:16:10 PDT
Created attachment 213498 [details] Patch for landing
WebKit Commit Bot
Comment 14 2013-10-06 00:31:54 PDT
Comment on attachment 213498 [details] Patch for landing Clearing flags on attachment: 213498 Committed r156985: <http://trac.webkit.org/changeset/156985>
WebKit Commit Bot
Comment 15 2013-10-06 00:31:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.