Bug 122190 - WebKit2 APIs returning CF and NS types should explicitly declare whether they return retained objects
Summary: WebKit2 APIs returning CF and NS types should explicitly declare whether they...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Rowe (bdash)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-01 15:27 PDT by Mark Rowe (bdash)
Modified: 2013-10-01 15:51 PDT (History)
1 user (show)

See Also:

Attachments
Patch (5.33 KB, patch)
2013-10-01 15:27 PDT, Mark Rowe (bdash) 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2013-10-01 15:27:14 PDT 
WebKit2 APIs returning CF and NS types should explicitly declare whether they return retained objects
Comment 1 Mark Rowe (bdash) 2013-10-01 15:27:43 PDT 
Created attachment 213127 [details]
Patch
Comment 2 WebKit Commit Bot 2013-10-01 15:29:44 PDT 
Attachment 213127 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/API/c/cf/WKErrorCF.h', u'Source/WebKit2/Shared/API/c/cf/WKStringCF.h', u'Source/WebKit2/Shared/API/c/cf/WKURLCF.h', u'Source/WebKit2/Shared/API/c/cg/WKImageCG.h', u'Source/WebKit2/Shared/API/c/mac/WKURLRequestNS.h', u'Source/WebKit2/Shared/API/c/mac/WKURLResponseNS.h', u'Source/WebKit2/UIProcess/API/C/cg/WKIconDatabaseCG.h']" exit_code: 1
Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Rowe (bdash) 2013-10-01 15:51:34 PDT 
Landed in r156743.