RESOLVED FIXED 122190
WebKit2 APIs returning CF and NS types should explicitly declare whether they return retained objects 
https://bugs.webkit.org/show_bug.cgi?id=122190
Summary WebKit2 APIs returning CF and NS types should explicitly declare whether they...
Mark Rowe (bdash)
Reported 2013-10-01 15:27:14 PDT
WebKit2 APIs returning CF and NS types should explicitly declare whether they return retained objects
Attachments
Patch (5.33 KB, patch)
2013-10-01 15:27 PDT, Mark Rowe (bdash) 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2013-10-01 15:27:43 PDT
Created attachment 213127 [details] Patch
WebKit Commit Bot
Comment 2 2013-10-01 15:29:44 PDT
Attachment 213127 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/API/c/cf/WKErrorCF.h', u'Source/WebKit2/Shared/API/c/cf/WKStringCF.h', u'Source/WebKit2/Shared/API/c/cf/WKURLCF.h', u'Source/WebKit2/Shared/API/c/cg/WKImageCG.h', u'Source/WebKit2/Shared/API/c/mac/WKURLRequestNS.h', u'Source/WebKit2/Shared/API/c/mac/WKURLResponseNS.h', u'Source/WebKit2/UIProcess/API/C/cg/WKIconDatabaseCG.h']" exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Rowe (bdash)
Comment 3 2013-10-01 15:51:34 PDT
Landed in r156743.
Note You need to log in before you can comment on or make changes to this bug.