Bug 122179 - [Mac] Set NSApplication current event while sending events directly to views
Summary: [Mac] Set NSApplication current event while sending events directly to views
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-01 14:23 PDT by Alexey Proskuryakov
Modified: 2013-10-01 15:44 PDT (History)
3 users (show)

See Also:

Attachments
proposed patch (8.03 KB, patch)
2013-10-01 14:26 PDT, Alexey Proskuryakov 		darin: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-10-01 14:23:30 PDT 
DumpRenderTree and WebKitTestRunner send events directly to WebHMTLView or WKView, which doesn't update [NSApp currentEvent]. But there are many places in WebKit that use the current event.

I think that some flakiness I'm seeing on bots and locally is because of this. Notably, tests that log mouse move events (like platform/mac/fast/events/objc-event-api.html) get fake events based on current event, and I'm guessing that they get incorrect modifiers from that.
Comment 1 Alexey Proskuryakov 2013-10-01 14:26:22 PDT 
Created attachment 213120 [details]
proposed patch
Comment 2 EFL EWS Bot 2013-10-01 14:45:08 PDT 
Comment on attachment 213120 [details]
proposed patch

Attachment 213120 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/2908174
Comment 3 Alexey Proskuryakov 2013-10-01 15:44:48 PDT 
Committed <http://trac.webkit.org/r154396>. EFL bot is wrong.