Bug 122168 - Consolidate multiple OSRExit calls into one.
Summary: Consolidate multiple OSRExit calls into one.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-01 11:55 PDT by Nadav Rotem
Modified: 2013-10-01 14:25 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.88 KB, patch)
2013-10-01 11:56 PDT, Nadav Rotem
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nadav Rotem 2013-10-01 11:55:50 PDT
Consolidate multiple OSRExit calls into one.
Comment 1 Nadav Rotem 2013-10-01 11:56:29 PDT
Created attachment 213105 [details]
Patch
Comment 2 Filip Pizlo 2013-10-01 12:06:42 PDT
Comment on attachment 213105 [details]
Patch

r=me.
Comment 3 Nadav Rotem 2013-10-01 13:52:18 PDT
should I cc commit-queue ?
Comment 4 Filip Pizlo 2013-10-01 14:02:12 PDT
(In reply to comment #3)
> should I cc commit-queue ?

You can set 'cq' to '?', and then a committer can set cq+.  I presume you want to commit so I will set cq+ for you.

The convention is that if a patch is sitting without cq? then it shouldn't be landed, under the assumption that the patch author is still doing some additional tests.  But if the patch author sets cq?, then any committer can set cq+ to auto-land it, or land it themselves.
Comment 5 WebKit Commit Bot 2013-10-01 14:25:13 PDT
Comment on attachment 213105 [details]
Patch

Clearing flags on attachment: 213105

Committed r156734: <http://trac.webkit.org/changeset/156734>
Comment 6 WebKit Commit Bot 2013-10-01 14:25:16 PDT
All reviewed patches have been landed.  Closing bug.