Bug 122161 - [iOS] WebCore fails to build with newer versions of clang
Summary: [iOS] WebCore fails to build with newer versions of clang
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-01 09:06 PDT by Daniel Bates
Modified: 2013-10-01 09:39 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.11 KB, patch)
2013-10-01 09:13 PDT, Daniel Bates 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2013-10-01 09:06:40 PDT 
Make WebCore build with newer versions of clang.
Comment 1 Daniel Bates 2013-10-01 09:13:08 PDT 
Created attachment 213090 [details]
Patch
Comment 2 Darin Adler 2013-10-01 09:22:40 PDT 
Comment on attachment 213090 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213090&action=review

> Source/WebCore/platform/network/mac/ResourceResponseMac.mm:97
> +static const size_t numberOfCommonHeaderFields = sizeof(commonHeaderFields) / sizeof(AtomicString*);

Would be much nicer to use the WTF_ARRAY_LENGTH macro instead and not give a name to this. The code here actually divides the size of the array by the size of a pointer to a different type!

> Source/WebCore/platform/network/mac/ResourceResponseMac.mm:135
> +            for (size_t i = 0; i < numberOfCommonHeaderFields; i++) {

Would just say:

    for (unsigned i = 0; i < WTF_ARRAY_LENGTH(commonHeaderFields); ++i)
Comment 3 Daniel Bates 2013-10-01 09:30:32 PDT 
(In reply to comment #2)
> (From update of attachment 213090 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=213090&action=review
> 
> > Source/WebCore/platform/network/mac/ResourceResponseMac.mm:97
> > +static const size_t numberOfCommonHeaderFields = sizeof(commonHeaderFields) / sizeof(AtomicString*);
> 
> Would be much nicer to use the WTF_ARRAY_LENGTH macro instead and not give a name to this. The code here actually divides the size of the array by the size of a pointer to a different type!
> 

Oops! You're right.

> > Source/WebCore/platform/network/mac/ResourceResponseMac.mm:135
> > +            for (size_t i = 0; i < numberOfCommonHeaderFields; i++) {
> 
> Would just say:
> 
>     for (unsigned i = 0; i < WTF_ARRAY_LENGTH(commonHeaderFields); ++i)

Will fix.
Comment 4 Daniel Bates 2013-10-01 09:39:07 PDT 
Committed r156715: <http://trac.webkit.org/changeset/156715>