RESOLVED FIXED122157
Generate toCSSFooValue for CSS child values 
https://bugs.webkit.org/show_bug.cgi?id=122157
Summary Generate toCSSFooValue for CSS child values
Gyuyoung Kim
Reported 2013-10-01 05:26:01 PDT
As a step to cleanup static_cast<> for CSSFooValue, this patch adds toCSSFooValue() for "CSSAspectRatioValue, CSSBorderImageSliceValue, CSSFunctionValue, CSSInheritedValue, CSSValueList, CSSVariableValue, and CSSFontFaceSrcValue". To use CSS_VALUE_TYPE_CASTS, isFunctionValue(), isFontFaceSrcValue() are added to generate toCSSFunctionValue, toCSSFontFaceSrcValue().
Attachments
Patch (32.30 KB, patch)
2013-10-01 05:29 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2013-10-01 05:29:04 PDT
Created attachment 213075 [details] Patch
Darin Adler
Comment 2 2013-10-01 09:56:00 PDT
Comment on attachment 213075 [details] Patch Please run WebKit tests before landing this. The last toXXX patch was hitting assertions a lot on the bots.
Gyuyoung Kim
Comment 3 2013-10-01 17:51:01 PDT
(In reply to comment #2) > (From update of attachment 213075 [details]) > Please run WebKit tests before landing this. The last toXXX patch was hitting assertions a lot on the bots. Ok, I will land after checking if regression happens.
Gyuyoung Kim
Comment 4 2013-10-01 20:47:17 PDT
Comment on attachment 213075 [details] Patch I ran layout test on mac wk2 as debug. It looks there is no regression there.
WebKit Commit Bot
Comment 5 2013-10-01 21:16:00 PDT
Comment on attachment 213075 [details] Patch Clearing flags on attachment: 213075 Committed r156760: <http://trac.webkit.org/changeset/156760>
WebKit Commit Bot
Comment 6 2013-10-01 21:16:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.