Bug 122157 - Generate toCSSFooValue for CSS child values
Summary: Generate toCSSFooValue for CSS child values
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-01 05:26 PDT by Gyuyoung Kim
Modified: 2013-10-01 21:16 PDT (History)
1 user (show)

See Also:

Attachments
Patch (32.30 KB, patch)
2013-10-01 05:29 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2013-10-01 05:26:01 PDT 
As a step to cleanup static_cast<> for CSSFooValue, this patch adds toCSSFooValue() for "CSSAspectRatioValue, CSSBorderImageSliceValue, CSSFunctionValue, CSSInheritedValue, CSSValueList, CSSVariableValue, and CSSFontFaceSrcValue". To use CSS_VALUE_TYPE_CASTS, isFunctionValue(), isFontFaceSrcValue() are added to generate toCSSFunctionValue, toCSSFontFaceSrcValue().
Comment 1 Gyuyoung Kim 2013-10-01 05:29:04 PDT 
Created attachment 213075 [details]
Patch
Comment 2 Darin Adler 2013-10-01 09:56:00 PDT 
Comment on attachment 213075 [details]
Patch

Please run WebKit tests before landing this. The last toXXX patch was hitting assertions a lot on the bots.
Comment 3 Gyuyoung Kim 2013-10-01 17:51:01 PDT 
(In reply to comment #2)
> (From update of attachment 213075 [details])
> Please run WebKit tests before landing this. The last toXXX patch was hitting assertions a lot on the bots.

Ok, I will land after checking if regression happens.
Comment 4 Gyuyoung Kim 2013-10-01 20:47:17 PDT 
Comment on attachment 213075 [details]
Patch

I ran layout test on mac wk2 as debug. It looks there is no regression there.
Comment 5 WebKit Commit Bot 2013-10-01 21:16:00 PDT 
Comment on attachment 213075 [details]
Patch

Clearing flags on attachment: 213075

Committed r156760: <http://trac.webkit.org/changeset/156760>
Comment 6 WebKit Commit Bot 2013-10-01 21:16:02 PDT 
All reviewed patches have been landed.  Closing bug.