Bug 122151 – Web Inspector: evaluate and show a popover for selected text in JS source when paused

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Antoine Quint]

<rdar://problem/14043399>

[Antoine Quint]

Expanding the popover on hover, we should show the popover for the expression of the selected text. This gives the user more control over what to evaluate if the expression is hard to figure out by hover alone.

[Antoine Quint]

Created attachment 213068 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 213068 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213068&action=review

r=me

> Source/WebInspectorUI/UserInterface/CodeMirrorTokenTrackingController.js:168
> +            if (highlightedRange.from.line === range.start.line &&
> +                highlightedRange.from.ch === range.start.ch &&
> +                highlightedRange.to.line === range.end.line &&
> +                highlightedRange.to.ch === range.end.ch)

This could use WebInspector.compareCodeMirrorPositions:

    if (WebInspector.compareCodeMirrorPositions(highlightedRange.from, range.start) === 0 &&
        WebInspector.compareCodeMirrorPositions(highlightedRange.to, range.end) === 0)

But what you have is just fine!

[Antoine Quint]

(In reply to comment #3)
> (From update of attachment 213068 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=213068&action=review
> 
> r=me
> 
> > Source/WebInspectorUI/UserInterface/CodeMirrorTokenTrackingController.js:168
> > +            if (highlightedRange.from.line === range.start.line &&
> > +                highlightedRange.from.ch === range.start.ch &&
> > +                highlightedRange.to.line === range.end.line &&
> > +                highlightedRange.to.ch === range.end.ch)
> 
> This could use WebInspector.compareCodeMirrorPositions:
> 
>     if (WebInspector.compareCodeMirrorPositions(highlightedRange.from, range.start) === 0 &&
>         WebInspector.compareCodeMirrorPositions(highlightedRange.to, range.end) === 0)
> 
> But what you have is just fine!

Much better, I'll change that in the commit.

[Antoine Quint]

Created attachment 213107 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 213107 [details]
Patch for landing

Clearing flags on attachment: 213107

Committed r156728: <http://trac.webkit.org/changeset/156728>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.