Bug 122121 - Remove timeout from shouldBecome* functions in js-test-pre
Summary: Remove timeout from shouldBecome* functions in js-test-pre
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-30 13:12 PDT by Alexey Proskuryakov
Modified: 2013-09-30 13:46 PDT (History)
0 users

See Also:

Attachments
proposed patch (4.08 KB, patch)
2013-09-30 13:15 PDT, Alexey Proskuryakov 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-09-30 13:12:58 PDT 
There is a family of functions in js-test-pre that check a condition every 5 milliseconds, and fail if it doesn't become true in 0.5 sec. They also take an argument for custom timeout, but there are no tests that pass it.

This is not how you write regression tests - anything can take longer than 0.5 seconds. We should just use global test timeout, not roll out ad hoc flaky solutions.

There is a lot of flakiness on tests such as editing/spelling/grammar-paste.html, and it seems entirely expected with a short timeout like this.
Comment 1 Alexey Proskuryakov 2013-09-30 13:15:14 PDT 
Created attachment 213032 [details]
proposed patch
Comment 2 Alexey Proskuryakov 2013-09-30 13:46:37 PDT 
Committed <http://trac.webkit.org/r156678>.