RESOLVED FIXED Bug 122121
Remove timeout from shouldBecome* functions in js-test-pre 
https://bugs.webkit.org/show_bug.cgi?id=122121
Summary Remove timeout from shouldBecome* functions in js-test-pre
Alexey Proskuryakov
Reported 2013-09-30 13:12:58 PDT
There is a family of functions in js-test-pre that check a condition every 5 milliseconds, and fail if it doesn't become true in 0.5 sec. They also take an argument for custom timeout, but there are no tests that pass it. This is not how you write regression tests - anything can take longer than 0.5 seconds. We should just use global test timeout, not roll out ad hoc flaky solutions. There is a lot of flakiness on tests such as editing/spelling/grammar-paste.html, and it seems entirely expected with a short timeout like this.
Attachments
proposed patch (4.08 KB, patch)
2013-09-30 13:15 PDT, Alexey Proskuryakov 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-09-30 13:15:14 PDT
Created attachment 213032 [details] proposed patch
Alexey Proskuryakov
Comment 2 2013-09-30 13:46:37 PDT
Committed <http://trac.webkit.org/r156678>.
Note You need to log in before you can comment on or make changes to this bug.