Bug 122120 – [GTK] Enable respect image orientation by default

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Anton Obzhirov]

[GTK] Add WK2 settings property for respect image orientation

[Anton Obzhirov]

Created attachment 213029 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Carlos Garcia Campos]

Comment on attachment 213029 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213029&action=review

I'm sorry I forgot to say in the other bug that you should also update the WebKitSettings unit tests. This is new API, so at least another GTK+ reviewer should approve it.

> Source/WebKit2/ChangeLog:8
> +        Add respect image orientation property in WK2

You should explain this a bit better, this is not a new property of WK2, but a new setting/property added to WebKitSettings API.

[Anton Obzhirov]

Created attachment 213076 [details]
Patch

[Anton Obzhirov]

Created attachment 213077 [details]
Patch

[Gustavo Noronha (kov)]

Comment on attachment 213077 [details]
Patch

In principle I'm OK with the new API, but in the spirit of only adding features that are really needed to our new API I am wondering why would anyone want to disable this setting? Is there a use-case in sight, or is this a just-in-case thing?

[Anton Obzhirov]

(In reply to comment #6)
> (From update of attachment 213077 [details])
> In principle I'm OK with the new API, but in the spirit of only adding features that are really needed to our new API I am wondering why would anyone want to disable this setting? Is there a use-case in sight, or is this a just-in-case thing?
It is useful option to disable/enable orientation - some sites can be designed not to take it into account for example. Also for the photo preview it can be useful sometime to preview photo in a way it was taken.

[Anton Obzhirov]

Thanks Simon for the link - additional arguments about having setting to enable/disable image orientation can be found here:
https://bugs.webkit.org/show_bug.cgi?id=19688.

[Anton Obzhirov]

Created attachment 214155 [details]
Patch

[Anton Obzhirov]

After checking with Carlos and Gustavo: instead of adding the setting respect image orientation will be enabled by default.

[Gustavo Noronha (kov)]

Comment on attachment 214155 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214155&action=review

> Source/WebKit2/ChangeLog:4
> +        [GTK] Add WK2 settings property for respect image orientation
> +        https://bugs.webkit.org/show_bug.cgi?id=122120

LGTM, except this bug title is no longer correct, just fix the changelog, please? =)

[Mario Sanchez Prada]

Committed r157861: <http://trac.webkit.org/changeset/157861>