Bug 122117 - getHostCallReturnValue needs to be implemented for Win64
Summary: getHostCallReturnValue needs to be implemented for Win64
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-30 12:39 PDT by Alex Christensen
Modified: 2013-09-30 12:50 PDT (History)
3 users (show)

See Also:


Attachments
patch (1.27 KB, patch)
2013-09-30 12:42 PDT, Alex Christensen
msaboff: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-09-30 12:39:04 PDT
r156490 broke the Win64 build.  getHostCallReturnValue is now used but not implemented for Win64, which has no inline assembly capabilities.  I based my assembly off the GCC assembly in JITOperations.cpp, and it works well enough to run sunspider.  The Win64 test infrastructure still needs some improvements.
Comment 1 Alex Christensen 2013-09-30 12:42:08 PDT
Created attachment 213026 [details]
patch
Comment 2 Alex Christensen 2013-09-30 12:50:56 PDT
r156670