Bug 122115 – Don't attempt to destroy decoded frame if a BitmapImage doesn't have encoded raw data.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Yongjun Zhang]

With BitmapImage::create(PassNativeImagePtr, ImageObserver*), a BitmapImage could be created by passing a native image.  If this image is added to memory cache, we shouldn't attempt to destroy its decoded frames since there is no encoded raw data and we won't be able to reconstruct the image again.

[Yongjun Zhang]

Created attachment 213021 [details]
Patch.

[Daniel Bates]

Comment on attachment 213021 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=213021&action=review

> Source/WebCore/ChangeLog:7
> +        passing a native image.  If this image is added to memory cache, we shouldn't attempt to destroy

Nit: "added to memory cache" => "added to the memory cache"

> Source/WebCore/ChangeLog:10
> +        Reviewed by NOBODY (OOPS!).

Nit: This line should come after the bug URL.

> Source/WebCore/ChangeLog:13
> +        No new tests for now. Currently there is no code patch to add an BitmapImage created by native image
> +        to memory cache, we will add this in future.

The second sentence doesn't read well. Maybe:

Currently there isn't a code path to add to the memory cache a BitmapImage that was created by adopting a native image. We'll add such a code path in a subsequent patch.

[Yongjun Zhang]

Created attachment 213034 [details]
Address review comments.

[WebKit Commit Bot]

Comment on attachment 213034 [details]
Address review comments.

Clearing flags on attachment: 213034

Committed r156681: <http://trac.webkit.org/changeset/156681>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.