Bug 122101 - Generate toCSSFooValue for CSSPrimitiveValue
Summary: Generate toCSSFooValue for CSSPrimitiveValue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-30 05:06 PDT by Gyuyoung Kim
Modified: 2013-10-01 03:49 PDT (History)
1 user (show)

See Also:

Attachments
Patch (85.38 KB, patch)
2013-09-30 05:12 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (86.12 KB, patch)
2013-09-30 20:36 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (85.89 KB, patch)
2013-09-30 21:05 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch for landing (85.83 KB, patch)
2013-10-01 03:03 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2013-09-30 05:06:07 PDT 
As a step of cleanup static_cast<> in CSSValues, this patch generates toCSSFooPrimitiveValue() in order to detect bad casts as well as improves code readability.
Comment 1 Gyuyoung Kim 2013-09-30 05:12:24 PDT 
Created attachment 212982 [details]
Patch
Comment 2 WebKit Commit Bot 2013-09-30 05:15:35 PDT 
Attachment 212982 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/CSSImageGeneratorValue.cpp', u'Source/WebCore/css/CSSImageSetValue.cpp', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/css/CSSPrimitiveValue.h', u'Source/WebCore/css/CSSToStyleMap.cpp', u'Source/WebCore/css/CSSValue.cpp', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/css/MediaList.cpp', u'Source/WebCore/css/MediaQueryEvaluator.cpp', u'Source/WebCore/css/SVGCSSStyleSelector.cpp', u'Source/WebCore/css/StylePropertySet.cpp', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/css/TransformFunctions.cpp', u'Source/WebCore/css/ViewportStyleResolver.cpp', u'Source/WebCore/css/WebKitCSSMatrix.cpp', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/EditingStyle.cpp', u'Source/WebCore/editing/markup.cpp']" exit_code: 1
Source/WebCore/css/TransformFunctions.cpp:285:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gyuyoung Kim 2013-09-30 20:36:49 PDT 
Created attachment 213049 [details]
Patch
Comment 4 WebKit Commit Bot 2013-09-30 20:37:55 PDT 
Attachment 213049 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/CSSGradientValue.cpp', u'Source/WebCore/css/CSSImageGeneratorValue.cpp', u'Source/WebCore/css/CSSImageSetValue.cpp', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/css/CSSPrimitiveValue.h', u'Source/WebCore/css/CSSToStyleMap.cpp', u'Source/WebCore/css/CSSValue.cpp', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/css/MediaList.cpp', u'Source/WebCore/css/MediaQueryEvaluator.cpp', u'Source/WebCore/css/SVGCSSStyleSelector.cpp', u'Source/WebCore/css/StylePropertySet.cpp', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/css/TransformFunctions.cpp', u'Source/WebCore/css/ViewportStyleResolver.cpp', u'Source/WebCore/css/WebKitCSSMatrix.cpp', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/EditingStyle.cpp', u'Source/WebCore/editing/markup.cpp']" exit_code: 1
Source/WebCore/css/TransformFunctions.cpp:285:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Gyuyoung Kim 2013-09-30 21:05:00 PDT 
Created attachment 213051 [details]
Patch
Comment 6 Gyuyoung Kim 2013-10-01 03:03:19 PDT 
Created attachment 213069 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2013-10-01 03:49:31 PDT 
Comment on attachment 213069 [details]
Patch for landing

Clearing flags on attachment: 213069

Committed r156705: <http://trac.webkit.org/changeset/156705>
Comment 8 WebKit Commit Bot 2013-10-01 03:49:34 PDT 
All reviewed patches have been landed.  Closing bug.