Bug 122088 - Remove FontTranscoder
Summary: Remove FontTranscoder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-30 00:54 PDT by Antti Koivisto
Modified: 2013-09-30 10:05 PDT (History)
4 users (show)

See Also:

Attachments
patch (38.87 KB, patch)
2013-09-30 01:07 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
another (31.08 KB, patch)
2013-09-30 01:14 PDT, Antti Koivisto 		kling: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-09-30 00:54:41 PDT 
This overly generic class just implements mapping of backslash to yen symbol for some legacy Japanese fonts.
Comment 1 Antti Koivisto 2013-09-30 01:07:27 PDT 
Created attachment 212959 [details]
patch
Comment 2 Antti Koivisto 2013-09-30 01:14:55 PDT 
Created attachment 212961 [details]
another
Comment 3 EFL EWS Bot 2013-09-30 02:26:48 PDT 
Comment on attachment 212961 [details]
another

Attachment 212961 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/2702155
Comment 4 Andreas Kling 2013-09-30 09:07:57 PDT 
Comment on attachment 212961 [details]
another

r=me

Also, wat.
Comment 5 Antti Koivisto 2013-09-30 09:22:00 PDT 
https://trac.webkit.org/r156657
Comment 6 Alexey Proskuryakov 2013-09-30 09:48:44 PDT 
> Also, wat.

I can explain wat, and would have r-ed the patch.

The idea was to use this class for other types of non-Unicode font transcoding. See bug 14637 and bug 22339. We just didn't do the work.
Comment 7 Sam Weinig 2013-09-30 09:52:04 PDT 
(In reply to comment #6)
> > Also, wat.
> 
> I can explain wat, and would have r-ed the patch.
> 
> The idea was to use this class for other types of non-Unicode font transcoding. See bug 14637 and bug 22339. We just didn't do the work.

Given how long that work has not been completed for, it seems like this patch is justified.  If we ever do that work, this (or something else) can be brought back.
Comment 8 Antti Koivisto 2013-09-30 10:05:52 PDT 
Abstractions are costly in terms of code clarity and often performance. They should only be added for a concrete need.