Bug 122070 - Regression: :after content can fail to repaint borders
Summary: Regression: :after content can fail to repaint borders
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philip Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-28 22:07 PDT by Philip Rogers
Modified: 2013-09-29 15:14 PDT (History)
8 users (show)

See Also:

Attachments
Testcase (983 bytes, text/html)
2013-09-28 22:07 PDT, Philip Rogers 		no flags Details
Patch (7.86 KB, patch)
2013-09-28 22:37 PDT, Philip Rogers 		no flags Details | Formatted Diff | Diff
Patch (13.25 KB, patch)
2013-09-29 14:40 PDT, Philip Rogers 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Rogers 2013-09-28 22:07:20 PDT 
Created attachment 212912 [details]
Testcase

wkrev.com/150259 introduced a regression where :after content with borders or outlines can fail to repaint correctly.

Patch forthcoming.
Comment 1 Philip Rogers 2013-09-28 22:37:49 PDT 
Created attachment 212913 [details]
Patch
Comment 2 Andreas Kling 2013-09-29 06:54:55 PDT 
Comment on attachment 212913 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212913&action=review

r=me, great find!

> Source/WebCore/rendering/RenderElement.cpp:300
> -    return diff == StyleDifferenceRepaint || (diff == StyleDifferenceRepaintIfText && hasImmediateNonWhitespaceTextChild());
> +    return diff == StyleDifferenceRepaint || (diff == StyleDifferenceRepaintIfText && hasImmediateNonWhitespaceTextChildOrBorderOrOutline());

The name StyleDifferenceRepaintIfText is no longer entirely accurate.
StyleDifferenceRepaintIfTextOrBorderOrOutline? :|
Comment 3 Philip Rogers 2013-09-29 14:40:24 PDT 
Created attachment 212933 [details]
Patch
Comment 4 Philip Rogers 2013-09-29 14:44:15 PDT 
Comment on attachment 212933 [details]
Patch

Thanks for the quick review! I updated the enum value to reflect what it actually does (StyleDifferenceRepaintIfTextOrBorderOrOutline).

Off to the CQ for you, patch.
Comment 5 WebKit Commit Bot 2013-09-29 15:14:51 PDT 
Comment on attachment 212933 [details]
Patch

Clearing flags on attachment: 212933

Committed r156619: <http://trac.webkit.org/changeset/156619>
Comment 6 WebKit Commit Bot 2013-09-29 15:14:54 PDT 
All reviewed patches have been landed.  Closing bug.