Bug 122059 - Generate toCSSFooValue for CSSImageGeneratorValue
Summary: Generate toCSSFooValue for CSSImageGeneratorValue
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-28 03:39 PDT by Gyuyoung Kim
Modified: 2022-07-13 15:29 PDT (History)
10 users (show)

See Also:


Attachments
Patch (6.23 KB, patch)
2013-09-28 03:40 PDT, Gyuyoung Kim
koivisto: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2013-09-28 03:39:57 PDT
We can detect bad cast as well as improve readability when using toCSSImageGeneratorValue.
Comment 1 Gyuyoung Kim 2013-09-28 03:40:45 PDT
Created attachment 212893 [details]
Patch
Comment 2 WebKit Commit Bot 2013-09-29 22:28:40 PDT
Comment on attachment 212893 [details]
Patch

Rejecting attachment 212893 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 212893, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ching file Source/WebCore/css/CSSImageGeneratorValue.h
patching file Source/WebCore/css/StyleResolver.cpp
Hunk #2 succeeded at 3097 (offset -1 lines).
patching file Source/WebCore/rendering/style/StylePendingImage.h
Hunk #1 FAILED at 49.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/style/StylePendingImage.h.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/2799057
Comment 3 Sergio Villar Senin 2014-01-31 06:26:02 PST
Gyuyoung are you updating the patch? Looks correct to me and anttik have already gave you the r+, it's just a matter of rebasing.
Comment 4 Gyuyoung Kim 2014-01-31 19:26:53 PST
(In reply to comment #3)
> Gyuyoung are you updating the patch? Looks correct to me and anttik have already gave you the r+, it's just a matter of rebasing.

Oops, I forget this patch. Now I can't rebase this one because of korean holiday season. I will land this patch as soon as finishing the holiday.
Comment 5 Brent Fulgham 2022-07-13 15:29:50 PDT
This code has been significantly refactored since this patch was proposed. There doesn't seem to be any action we can take here.