Bug 122059 – Generate toCSSFooValue for CSSImageGeneratorValue

• Status: RESOLVED
• Resolution: CONFIGURATION CHANGED
• Component: CSS

[Gyuyoung Kim]

We can detect bad cast as well as improve readability when using toCSSImageGeneratorValue.

[Gyuyoung Kim]

Created attachment 212893 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 212893 [details]
Patch

Rejecting attachment 212893 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 212893, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ching file Source/WebCore/css/CSSImageGeneratorValue.h
patching file Source/WebCore/css/StyleResolver.cpp
Hunk #2 succeeded at 3097 (offset -1 lines).
patching file Source/WebCore/rendering/style/StylePendingImage.h
Hunk #1 FAILED at 49.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/style/StylePendingImage.h.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/2799057

[Sergio Villar Senin]

Gyuyoung are you updating the patch? Looks correct to me and anttik have already gave you the r+, it's just a matter of rebasing.

[Gyuyoung Kim]

(In reply to comment #3)
> Gyuyoung are you updating the patch? Looks correct to me and anttik have already gave you the r+, it's just a matter of rebasing.

Oops, I forget this patch. Now I can't rebase this one because of korean holiday season. I will land this patch as soon as finishing the holiday.

[Brent Fulgham]

This code has been significantly refactored since this patch was proposed. There doesn't seem to be any action we can take here.