Bug 122055 - Generate toCSSCalcValue instead of using manual cast function
Summary: Generate toCSSCalcValue instead of using manual cast function
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
Depends on:
Reported: 2013-09-28 02:14 PDT by Gyuyoung Kim
Modified: 2013-09-30 03:37 PDT (History)
7 users (show)

See Also:

Patch (3.96 KB, patch)
2013-09-28 02:34 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch for landing (3.98 KB, patch)
2013-09-30 03:02 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2013-09-28 02:14:05 PDT
Generated type cast function supports more plenty functions rather than manual functions. To use CSS_VALUE_TYPE_CAST, isCalculationValue() needs to be changed with isCalcValue().
Comment 1 Gyuyoung Kim 2013-09-28 02:34:54 PDT
Created attachment 212889 [details]
Comment 2 WebKit Commit Bot 2013-09-29 22:37:09 PDT
Comment on attachment 212889 [details]

Rejecting attachment 212889 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 212889, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
fs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 156628 = b82966624cb7cee21b84e3d907f42f367ef0091f
r156629 = 146b3b7b48db83e8b7b0f7cac26d5970e499e021
r156630 = c43751f7cd3a85f5d46bbe60083e939532c42532
r156631 = cd657cfb236387a0d41720e342f664a068e37961
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.appspot.com/results/2801035
Comment 3 Gyuyoung Kim 2013-09-30 03:02:33 PDT
Created attachment 212969 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2013-09-30 03:37:49 PDT
Comment on attachment 212969 [details]
Patch for landing

Clearing flags on attachment: 212969

Committed r156642: <http://trac.webkit.org/changeset/156642>
Comment 5 WebKit Commit Bot 2013-09-30 03:37:52 PDT
All reviewed patches have been landed.  Closing bug.