Bug 122053 - filter: drop-shadow doesnot support viewport units
Summary: filter: drop-shadow doesnot support viewport units
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: gur.trio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-28 00:50 PDT by gur.trio
Modified: 2013-09-28 09:12 PDT (History)
7 users (show)

See Also:

Attachments
Test case for filter: drop-shadow (323 bytes, text/html)
2013-09-28 00:50 PDT, gur.trio 		no flags Details
Patch (11.83 KB, patch)
2013-09-28 01:22 PDT, gur.trio 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description gur.trio 2013-09-28 00:50:05 PDT 
filter: drop-shadow doesnot support viewport units
Comment 1 gur.trio 2013-09-28 00:50:51 PDT 
Created attachment 212883 [details]
Test case for filter: drop-shadow
Comment 2 gur.trio 2013-09-28 01:22:39 PDT 
Created attachment 212885 [details]
Patch
Comment 3 Darin Adler 2013-09-28 08:48:23 PDT 
Comment on attachment 212885 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212885&action=review

> Source/WebCore/css/StyleResolver.cpp:3877
> +            if (item->x->isViewportPercentageLength())
> +                x = viewportPercentageValue(*item->x, x);

Maybe we should have a function that does this dance. I have noticed that we have to repeat this idiom at every call site. If the inline call to isViewportPercentageLength is important for performance, we can make the function do it inline. I’d want to go back and do this for as many of the places we use viewportPercentageValue as possible. I don’t like repetitive idioms like this one when they are unnecessary.
Comment 4 WebKit Commit Bot 2013-09-28 09:12:47 PDT 
Comment on attachment 212885 [details]
Patch

Clearing flags on attachment: 212885

Committed r156606: <http://trac.webkit.org/changeset/156606>
Comment 5 WebKit Commit Bot 2013-09-28 09:12:49 PDT 
All reviewed patches have been landed.  Closing bug.