RESOLVED FIXED 122052
Take Xcode's advice and enable some extra warnings 
https://bugs.webkit.org/show_bug.cgi?id=122052
Summary Take Xcode's advice and enable some extra warnings
Mark Rowe (bdash)
Reported 2013-09-28 00:38:08 PDT
Take Xcode's advice and enable some extra warnings
Attachments
Patch (14.02 KB, patch)
2013-09-28 00:38 PDT, Mark Rowe (bdash) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2013-09-28 00:38:23 PDT
Created attachment 212882 [details] Patch
WebKit Commit Bot
Comment 2 2013-09-28 00:40:37 PDT
Attachment 212882 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/Configurations/Base.xcconfig', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/WTF/ChangeLog', u'Source/WTF/Configurations/Base.xcconfig', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WebCore/ChangeLog', u'Source/WebCore/Configurations/Base.xcconfig', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/dom/NamedNodeMap.cpp', u'Source/WebKit/ChangeLog', u'Source/WebKit/WebKit.xcodeproj/project.pbxproj', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Configurations/Base.xcconfig', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Configurations/Base.xcconfig', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj']" exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WTF/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebKit/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/JavaScriptCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebKit/mac/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 6 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2013-09-28 12:14:31 PDT
Comment on attachment 212882 [details] Patch Clearing flags on attachment: 212882 Committed r156610: <http://trac.webkit.org/changeset/156610>
WebKit Commit Bot
Comment 4 2013-09-28 12:14:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.