122048 – WebKit fails to build with newer versions of clang

RESOLVED FIXED 122048

WebKit fails to build with newer versions of clang

https://bugs.webkit.org/show_bug.cgi?id=122048

Summary WebKit fails to build with newer versions of clang

Mark Rowe (bdash)

Reported 2013-09-27 18:50:43 PDT

Most of the WebKit projects fail to build in various ways with newer versions of clang. <rdar://problem/15079224>

Attachments
Fix an .xcconfig issue that affects several projects (24.83 KB, patch) 2013-09-27 18:53 PDT, Mark Rowe (bdash)	no flags	Details Formatted Diff Diff
Fix WTF (6.94 KB, patch) 2013-09-27 18:54 PDT, Mark Rowe (bdash)	no flags	Details Formatted Diff Diff
Fix JavaScriptCore (4.56 KB, patch) 2013-09-27 18:54 PDT, Mark Rowe (bdash)	no flags	Details Formatted Diff Diff
Fix WebKit (5.36 KB, patch) 2013-09-27 18:55 PDT, Mark Rowe (bdash)	no flags	Details Formatted Diff Diff
Fix WebKit2 (5.57 KB, patch) 2013-09-27 18:55 PDT, Mark Rowe (bdash)	no flags	Details Formatted Diff Diff
Fix WebCore (30.70 KB, patch) 2013-09-27 18:56 PDT, Mark Rowe (bdash)	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (502.79 KB, application/zip) 2013-09-27 19:41 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (522.37 KB, application/zip) 2013-09-27 20:09 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (521.56 KB, application/zip) 2013-09-27 21:07 PDT, Build Bot	no flags	Details
Fix WebCore v2 (18.99 KB, patch) 2013-09-27 21:49 PDT, Mark Rowe (bdash)	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Mark Rowe (bdash)

Comment 1 2013-09-27 18:52:33 PDT

I'm going to abuse the process a little bit and use this single bug for six patches: one to fix an issue with the Xcode configuration that causes failures in multiple projects, and five other patches to fix issues in individual projects.

Mark Rowe (bdash)

Comment 2 2013-09-27 18:53:57 PDT

Created attachment 212864 [details] Fix an .xcconfig issue that affects several projects

Mark Rowe (bdash)

Comment 3 2013-09-27 18:54:31 PDT

Created attachment 212865 [details] Fix WTF

Mark Rowe (bdash)

Comment 4 2013-09-27 18:54:54 PDT

Created attachment 212866 [details] Fix JavaScriptCore

Mark Rowe (bdash)

Comment 5 2013-09-27 18:55:19 PDT

Created attachment 212867 [details] Fix WebKit

WebKit Commit Bot

Comment 6 2013-09-27 18:55:35 PDT

Attachment 212864 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Configurations/WebCore.xcconfig', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Configurations/DebugRelease.xcconfig', u'Source/WebKit/mac/Configurations/WebKit.xcconfig', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Configurations/BaseTarget.xcconfig', u'Source/WebKit2/Configurations/DebugRelease.xcconfig', u'Tools/ChangeLog', u'Tools/DumpRenderTree/mac/Configurations/Base.xcconfig', u'Tools/DumpRenderTree/mac/Configurations/BaseTarget.xcconfig', u'Tools/DumpRenderTree/mac/Configurations/DebugRelease.xcconfig', u'Tools/DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig', u'Tools/DumpRenderTree/mac/Configurations/ImageDiff.xcconfig', u'Tools/DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig', u'Tools/WebKitTestRunner/Configurations/Base.xcconfig', u'Tools/WebKitTestRunner/Configurations/BaseTarget.xcconfig', u'Tools/WebKitTestRunner/Configurations/DebugRelease.xcconfig', u'Tools/WebKitTestRunner/Configurations/InjectedBundle.xcconfig', u'Tools/WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig']" exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebKit/mac/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 4 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

Mark Rowe (bdash)

Comment 7 2013-09-27 18:55:38 PDT

Created attachment 212868 [details] Fix WebKit2

Mark Rowe (bdash)

Comment 8 2013-09-27 18:56:01 PDT

Created attachment 212869 [details] Fix WebCore

WebKit Commit Bot

Comment 9 2013-09-27 18:58:35 PDT

Attachment 212865 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/DateMath.cpp', u'Source/WTF/wtf/FastMalloc.cpp', u'Source/WTF/wtf/TCSystemAlloc.cpp', u'Source/WTF/wtf/dtoa.cpp']" exit_code: 1 Source/WTF/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 10 2013-09-27 18:59:28 PDT

Attachment 212866 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/interpreter/Interpreter.cpp', u'Source/JavaScriptCore/parser/SourceProvider.cpp', u'Source/JavaScriptCore/runtime/GCActivityCallback.cpp', u'Source/JavaScriptCore/runtime/JSCJSValue.cpp', u'Source/JavaScriptCore/runtime/JSString.cpp']" exit_code: 1 Source/JavaScriptCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 11 2013-09-27 19:00:22 PDT

Attachment 212867 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/Carbon/HIWebView.mm', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/History/BinaryPropertyList.cpp', u'Source/WebKit/mac/Misc/WebIconDatabase.mm', u'Source/WebKit/mac/Plugins/WebBaseNetscapePluginView.mm', u'Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm']" exit_code: 1 Source/WebKit/mac/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 12 2013-09-27 19:01:17 PDT

Attachment 212868 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/VisitedLinkTable.cpp', u'Source/WebKit2/UIProcess/Plugins/mac/PluginInfoStoreMac.mm', u'Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm', u'Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm', u'Source/WebKit2/WebProcess/WebPage/FindController.cpp', u'Source/WebKit2/WebProcess/WebPage/WebBackForwardListProxy.cpp']" exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 13 2013-09-27 19:02:31 PDT

Attachment 212869 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/indexeddb/IDBIndex.cpp', u'Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp', u'Source/WebCore/Modules/webaudio/AudioContext.cpp', u'Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp', u'Source/WebCore/Modules/webdatabase/SQLResultSet.cpp', u'Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp', u'Source/WebCore/Modules/websockets/WebSocketHandshake.cpp', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/css/CSSGrammar.y.in', u'Source/WebCore/html/track/TextTrackCue.cpp', u'Source/WebCore/loader/TextResourceDecoder.cpp', u'Source/WebCore/page/ContentSecurityPolicy.cpp', u'Source/WebCore/page/ContentSecurityPolicy.h', u'Source/WebCore/page/DOMSecurityPolicy.cpp', u'Source/WebCore/page/DOMSecurityPolicy.h', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/platform/mac/DisplaySleepDisabler.cpp', u'Source/WebCore/platform/mac/WebCoreFullScreenWarningView.mm', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayerCompositor.cpp', u'Source/WebCore/svg/SVGAnimatedAngle.cpp', u'Source/WebCore/svg/SVGUseElement.cpp', u'Source/WebCore/xml/XPathStep.cpp']" exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 14 2013-09-27 19:41:58 PDT

Comment on attachment 212869 [details] Fix WebCore Attachment 212869 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/2648302 New failing tests: http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url.html http/tests/security/contentSecurityPolicy/script-src-none-inline-event.html inspector/debugger/debugger-pause-on-blocked-script-url.html http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy.html http/tests/security/contentSecurityPolicy/javascript-url-blocked.html inspector/debugger/debugger-pause-on-blocked-event-handler.html

Build Bot

Comment 15 2013-09-27 19:41:59 PDT

Created attachment 212872 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 16 2013-09-27 20:09:23 PDT

Comment on attachment 212869 [details] Fix WebCore Attachment 212869 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/2660337 New failing tests: http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url.html http/tests/security/contentSecurityPolicy/script-src-none-inline-event.html inspector/debugger/debugger-pause-on-blocked-script-url.html http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy.html http/tests/security/contentSecurityPolicy/javascript-url-blocked.html inspector/debugger/debugger-pause-on-blocked-event-handler.html

Build Bot

Comment 17 2013-09-27 20:09:25 PDT

Created attachment 212873 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Mark Rowe (bdash)

Comment 18 2013-09-27 21:00:54 PDT

Comment on attachment 212869 [details] Fix WebCore Looks like I did something wrong in the ContentSecurityPolicy parts of this patch. I'll revise it.

Build Bot

Comment 19 2013-09-27 21:07:31 PDT

Comment on attachment 212869 [details] Fix WebCore Attachment 212869 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/2660356 New failing tests: http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url.html http/tests/security/contentSecurityPolicy/script-src-none-inline-event.html inspector/debugger/debugger-pause-on-blocked-script-url.html http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy.html http/tests/security/contentSecurityPolicy/javascript-url-blocked.html inspector/debugger/debugger-pause-on-blocked-event-handler.html

Build Bot

Comment 20 2013-09-27 21:07:34 PDT

Created attachment 212874 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Mark Rowe (bdash)

Comment 21 2013-09-27 21:49:38 PDT

Created attachment 212875 [details] Fix WebCore v2

WebKit Commit Bot

Comment 22 2013-09-27 21:51:37 PDT

Attachment 212875 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/indexeddb/IDBIndex.cpp', u'Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp', u'Source/WebCore/Modules/webaudio/AudioContext.cpp', u'Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp', u'Source/WebCore/Modules/webdatabase/SQLResultSet.cpp', u'Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp', u'Source/WebCore/Modules/websockets/WebSocketHandshake.cpp', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/css/CSSGrammar.y.in', u'Source/WebCore/html/track/TextTrackCue.cpp', u'Source/WebCore/loader/TextResourceDecoder.cpp', u'Source/WebCore/page/ContentSecurityPolicy.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/platform/mac/DisplaySleepDisabler.cpp', u'Source/WebCore/platform/mac/WebCoreFullScreenWarningView.mm', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayerCompositor.cpp', u'Source/WebCore/svg/SVGAnimatedAngle.cpp', u'Source/WebCore/svg/SVGUseElement.cpp', u'Source/WebCore/xml/XPathStep.cpp']" exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 23 2013-09-28 03:18:26 PDT

Comment on attachment 212865 [details] Fix WTF Clearing flags on attachment: 212865 Committed r156596: <http://trac.webkit.org/changeset/156596>

WebKit Commit Bot

Comment 24 2013-09-28 03:20:52 PDT

Comment on attachment 212866 [details] Fix JavaScriptCore Clearing flags on attachment: 212866 Committed r156597: <http://trac.webkit.org/changeset/156597>

WebKit Commit Bot

Comment 25 2013-09-28 03:22:19 PDT

Comment on attachment 212868 [details] Fix WebKit2 Clearing flags on attachment: 212868 Committed r156598: <http://trac.webkit.org/changeset/156598>

WebKit Commit Bot

Comment 26 2013-09-28 03:24:13 PDT

Comment on attachment 212867 [details] Fix WebKit Clearing flags on attachment: 212867 Committed r156599: <http://trac.webkit.org/changeset/156599>

WebKit Commit Bot

Comment 27 2013-09-28 03:25:04 PDT

Comment on attachment 212875 [details] Fix WebCore v2 Clearing flags on attachment: 212875 Committed r156600: <http://trac.webkit.org/changeset/156600>

WebKit Commit Bot

Comment 28 2013-09-28 13:00:16 PDT

Comment on attachment 212864 [details] Fix an .xcconfig issue that affects several projects Clearing flags on attachment: 212864 Committed r156611: <http://trac.webkit.org/changeset/156611>

WebKit Commit Bot

Comment 29 2013-09-28 13:00:20 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware Unspecified

OS Unspecified

Product WebKit

Component WebKit Misc.

Assignee

Mark Rowe (bdash)

Reported

2013-09-27 18:50 PDT

Modified

2013-09-28 13:00 PDT History

CC List

6 users Show

URL

Keywords InRadar

Depends on

Blocks