Bug 122046 - Center misspelling dots across width of word
Summary: Center misspelling dots across width of word
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-27 17:58 PDT by Myles C. Maxfield
Modified: 2013-10-01 09:58 PDT (History)
3 users (show)

See Also:

Attachments
Patch (195.61 KB, patch)
2013-09-30 14:46 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (29.84 KB, patch)
2013-10-01 02:29 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2013-09-27 17:58:42 PDT 
Center misspelling dots across width of word
Comment 1 Myles C. Maxfield 2013-09-30 14:46:06 PDT 
Created attachment 213037 [details]
Patch
Comment 2 Darin Adler 2013-09-30 15:13:53 PDT 
Comment on attachment 213037 [details]
Patch

Code change looks fine. And the spelling markers all look better. But the grammar markers in the test results seems to have a different style, with wider lines rather than dots. What is going on there?
Comment 3 Myles C. Maxfield 2013-09-30 15:18:40 PDT 
The grammar dots come from calling + NSImage imageNamed: with @"NSGrammarDot" (and if that fails, then with @"GrammarDot"). I'm searching now for where these images are coming from.
Comment 4 Build Bot 2013-09-30 15:28:02 PDT 
Comment on attachment 213037 [details]
Patch

Attachment 213037 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/2802100
Comment 5 Myles C. Maxfield 2013-10-01 02:29:42 PDT 
Created attachment 213065 [details]
Patch
Comment 6 WebKit Commit Bot 2013-10-01 09:58:43 PDT 
Comment on attachment 213065 [details]
Patch

Clearing flags on attachment: 213065

Committed r156716: <http://trac.webkit.org/changeset/156716>
Comment 7 WebKit Commit Bot 2013-10-01 09:58:45 PDT 
All reviewed patches have been landed.  Closing bug.