WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 122046
Center misspelling dots across width of word
https://bugs.webkit.org/show_bug.cgi?id=122046
Summary
Center misspelling dots across width of word
Myles C. Maxfield
Reported
2013-09-27 17:58:42 PDT
Center misspelling dots across width of word
Attachments
Patch
(195.61 KB, patch)
2013-09-30 14:46 PDT
,
Myles C. Maxfield
no flags
Details
Formatted Diff
Diff
Patch
(29.84 KB, patch)
2013-10-01 02:29 PDT
,
Myles C. Maxfield
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1
2013-09-30 14:46:06 PDT
Created
attachment 213037
[details]
Patch
Darin Adler
Comment 2
2013-09-30 15:13:53 PDT
Comment on
attachment 213037
[details]
Patch Code change looks fine. And the spelling markers all look better. But the grammar markers in the test results seems to have a different style, with wider lines rather than dots. What is going on there?
Myles C. Maxfield
Comment 3
2013-09-30 15:18:40 PDT
The grammar dots come from calling + NSImage imageNamed: with @"NSGrammarDot" (and if that fails, then with @"GrammarDot"). I'm searching now for where these images are coming from.
Build Bot
Comment 4
2013-09-30 15:28:02 PDT
Comment on
attachment 213037
[details]
Patch
Attachment 213037
[details]
did not pass win-ews (win): Output:
http://webkit-queues.appspot.com/results/2802100
Myles C. Maxfield
Comment 5
2013-10-01 02:29:42 PDT
Created
attachment 213065
[details]
Patch
WebKit Commit Bot
Comment 6
2013-10-01 09:58:43 PDT
Comment on
attachment 213065
[details]
Patch Clearing flags on attachment: 213065 Committed
r156716
: <
http://trac.webkit.org/changeset/156716
>
WebKit Commit Bot
Comment 7
2013-10-01 09:58:45 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug