Bug 122032 - ASSERT(!m_hasBadParent) in InlineBox::parent() should be ASSERT_WITH_SECURITY_IMPLICATION
Summary: ASSERT(!m_hasBadParent) in InlineBox::parent() should be ASSERT_WITH_SECURITY...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Drew Yao
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-27 14:26 PDT by Drew Yao
Modified: 2013-09-30 14:54 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.24 KB, patch)
2013-09-27 14:39 PDT, Drew Yao
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Drew Yao 2013-09-27 14:26:02 PDT
Source/WebCore/rendering/InlineBox.h:

    InlineFlowBox* parent() const
    {
        ASSERT(!m_hasBadParent);
        return m_parent;
    }


ASSERT(!m_hasBadParent) in InlineBox::parent() should be ASSERT_WITH_SECURITY_IMPLICATION.  Its sole purpose is to catch use after free bugs.
Comment 1 Drew Yao 2013-09-27 14:39:19 PDT
Created attachment 212841 [details]
Patch
Comment 2 WebKit Commit Bot 2013-09-30 14:54:46 PDT
Comment on attachment 212841 [details]
Patch

Clearing flags on attachment: 212841

Committed r156682: <http://trac.webkit.org/changeset/156682>
Comment 3 WebKit Commit Bot 2013-09-30 14:54:48 PDT
All reviewed patches have been landed.  Closing bug.