Bug 122005 – Removing noisy compilation warnings after r156341

• Status: UNCONFIRMED
• Component: WebKit2

[Thiago de Barros Lacerda]

Unused parameters in encode and decode messages in Arguments.h are causing the warnings.
Also removed another warnings found on the way.

[Thiago de Barros Lacerda]

Created attachment 212787 [details]
Patch

[Anders Carlsson]

Comment on attachment 212787 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212787&action=review

> Source/WebKit2/Platform/CoreIPC/Arguments.h:59
>  
>  template<typename... Elements>
>  struct TupleCoder<0, Elements...> {
> -    static void encode(ArgumentEncoder& encoder, const std::tuple<Elements...>& tuple)
> +    static void encode(ArgumentEncoder&, const std::tuple<Elements...>&)
>      {
>      }
>  
> -    static bool decode(ArgumentDecoder& decoder, std::tuple<Elements...>& tuple)
> +    static bool decode(ArgumentDecoder&, std::tuple<Elements...>&)
>      {
>          return true;
>      }

This was landed in a separate patch.

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1290
> +#if !ENABLE(NETSCAPE_PLUGIN_API)
> +    UNUSED_PARAM(pluginElement);
> +#endif

I prefer having the code be:

#if ENABLE
#else
#endif

Same goes for all the !ENABLE #ifs.