It looks like the way to do this is with GstToc: http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/gstreamer-GstToc.html#gst-toc-entry-get-uid We can get these from GstMessages: http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/gstreamer-GstMessage.html#gst-message-parse-toc It looks like Matroska currently has the best support, but there's a TODO saying mp4 should support it too. mkvmerge can create these: http://www.bunkus.org/videotools/mkvtoolnix/doc/mkvmerge.html#mkvmerge.chapters I have a *very* basic patch (adding chapters to counting-subtitled-srt.mkv and printing out chapter contents) here. It's not even remotely done, but it might be useful for someone else who wants to finish this: https://github.com/cablelabs/webkit/commits/ruih/handle-table-of-contents
Created attachment 213009 [details] Patch
Comment on attachment 213009 [details] Patch Attachment 213009 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/2755120
Comment on attachment 213009 [details] Patch Attachment 213009 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/2815091
Created attachment 213014 [details] Add ENABLE(VIDEO_TRACK) checks
Comment on attachment 213014 [details] Add ENABLE(VIDEO_TRACK) checks View in context: https://bugs.webkit.org/attachment.cgi?id=213014&action=review > Source/WebCore/platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h:36 > +class InbandMetadataTextTrackPrivateGStreamer : public InbandTextTrackPrivate { Nit: FINAL > LayoutTests/media/in-band-cues.js:185 > + for (var i = 1; i < numInBandTracks + 1; ++i) { > + compareTracks("video.textTracks[" + (i + 1) + "]", "inbandTrack" + i); > + } Nit: braces aren't necessary here
(In reply to comment #5) > Nit: braces aren't necessary here I'm surprised the style checker let me do that. Since you set it to review+, I assume you don't think it's worth fixing and resubmitting?
Or is it intentionally still "commit-queue?" so someone else can review it?
(In reply to comment #7) > Or is it intentionally still "commit-queue?" so someone else can review it? You can update the patch and upload as "Patch for landing" and anyone will cq+ it.
Created attachment 213086 [details] Patch for landing Removed superfluous braces
Comment on attachment 213086 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=213086&action=review > Source/WebCore/platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h:36 > +class InbandMetadataTextTrackPrivateGStreamer : public InbandTextTrackPrivate { You forgot to mark this FINAL, but it is OK to fix this in a follow-up.
Comment on attachment 213086 [details] Patch for landing Clearing flags on attachment: 213086 Committed r156713: <http://trac.webkit.org/changeset/156713>
All reviewed patches have been landed. Closing bug.