Bug 121999 - [GCC] Fix build with gcc < 4.8.1, which does not have is_trivially_destructible
Summary: [GCC] Fix build with gcc < 4.8.1, which does not have is_trivially_destructible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gustavo Noronha (kov)
URL:
Keywords:
: 122008 (view as bug list)
Depends on:
Blocks: 121930
  Show dependency tree / graph
 
Reported: 2013-09-26 17:41 PDT by Gustavo Noronha (kov)
Modified: 2013-10-10 09:29 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.31 KB, patch)
2013-09-26 17:42 PDT, Gustavo Noronha (kov) 		no flags Details | Formatted Diff | Diff
Patch (1.45 KB, patch)
2013-09-26 18:45 PDT, Gustavo Noronha (kov) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2013-09-26 17:41:58 PDT 
[GCC] Fix build with gcc < 4.8.1, which does not have is_trivially_destructible
Comment 1 Gustavo Noronha (kov) 2013-09-26 17:42:15 PDT 
Created attachment 212775 [details]
Patch
Comment 2 Benjamin Poulain 2013-09-26 17:57:14 PDT 
Comment on attachment 212775 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212775&action=review

> Source/WTF/wtf/StdLibExtras.h:308
> +#if (defined(_MSC_VER) && _MSC_VER < 1700) || (COMPILER(GCC) && !(__GNUC__ >= 4 && __GNUC_MINOR__ >= 8 && __GNUC_PATCHLEVEL__ >= 1))

Ins't that reimplementing GCC_VERSION_AT_LEAST?

I am pretty sure Clang also matches COMPILER(GCC).

> Source/WTF/wtf/StdLibExtras.h:310
>  // Work-around for Pre-C++11 syntax in MSVC 2010 and prior

You need to fix the comment as well.
Comment 3 Gustavo Noronha (kov) 2013-09-26 18:36:32 PDT 
hah, I should have looked harder, I didn't know about GCC_VERSION_AT_LEAST, thanks, modified patch incoming in a bit, thanks!
Comment 4 Gustavo Noronha (kov) 2013-09-26 18:45:25 PDT 
Created attachment 212782 [details]
Patch
Comment 5 Benjamin Poulain 2013-09-26 19:56:42 PDT 
Comment on attachment 212782 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212782&action=review

> Source/WTF/wtf/StdLibExtras.h:310
> +// Work-around for Pre-C++11 syntax in MSVC 2010 and prior as well as GCC < 4.8.1.

Please add a comma to split "and prior as well as".
Comment 6 Ryuan Choi 2013-09-27 00:47:48 PDT 
Committed r156529: <http://trac.webkit.org/changeset/156529>
Comment 7 Ryuan Choi 2013-09-27 00:49:37 PDT 
Comment on attachment 212782 [details]
Patch

Clearing flags.

I landed manually after followed comment in order to fix build break on EFL, GTK and Qt bot.

Thanks.
Comment 8 Csaba Osztrogonác 2013-09-27 00:55:00 PDT 
*** Bug 122008 has been marked as a duplicate of this bug. ***
Comment 9 Csaba Osztrogonác 2013-10-10 09:29:04 PDT 
Adding the original bug (which broke the build) to blocks list.