RESOLVED FIXED 121986
Move CSS MatchRequest from StyleResolver to a private definition in ElementRuleCollector 
https://bugs.webkit.org/show_bug.cgi?id=121986
Summary Move CSS MatchRequest from StyleResolver to a private definition in ElementRu...
Benjamin Poulain
Reported 2013-09-26 15:11:57 PDT
Move CSS MatchRequest from StyleResolver to a private definition in ElementRuleCollector
Attachments
Patch (2.94 KB, patch)
2013-09-26 15:13 PDT, Benjamin Poulain 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2013-09-26 15:13:06 PDT
Created attachment 212758 [details] Patch
Andreas Kling
Comment 2 2013-09-26 15:59:30 PDT
Comment on attachment 212758 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212758&action=review Coolio. > Source/WebCore/css/ElementRuleCollector.h:82 > + const RuleSet* ruleSet; Could we make this a RuleSet&?
Andreas Kling
Comment 3 2013-09-26 16:00:33 PDT
If you only need MatchRequest inside ElementRuleCollector.cpp, consider moving the class definition into ElementRuleCollector.cpp. You could forward declare it inside ElementRuleCollector to maintain the class nesting.
Benjamin Poulain
Comment 4 2013-09-26 16:35:15 PDT
Committed r156515: <http://trac.webkit.org/changeset/156515>
Note You need to log in before you can comment on or make changes to this bug.