Bug 121986 - Move CSS MatchRequest from StyleResolver to a private definition in ElementRuleCollector
Summary: Move CSS MatchRequest from StyleResolver to a private definition in ElementRu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-26 15:11 PDT by Benjamin Poulain
Modified: 2013-09-26 16:35 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.94 KB, patch)
2013-09-26 15:13 PDT, Benjamin Poulain 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-09-26 15:11:57 PDT 
Move CSS MatchRequest from StyleResolver to a private definition in ElementRuleCollector
Comment 1 Benjamin Poulain 2013-09-26 15:13:06 PDT 
Created attachment 212758 [details]
Patch
Comment 2 Andreas Kling 2013-09-26 15:59:30 PDT 
Comment on attachment 212758 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212758&action=review

Coolio.

> Source/WebCore/css/ElementRuleCollector.h:82
> +        const RuleSet* ruleSet;

Could we make this a RuleSet&?
Comment 3 Andreas Kling 2013-09-26 16:00:33 PDT 
If you only need MatchRequest inside ElementRuleCollector.cpp, consider moving the class definition into ElementRuleCollector.cpp.

You could forward declare it inside ElementRuleCollector to maintain the class nesting.
Comment 4 Benjamin Poulain 2013-09-26 16:35:15 PDT 
Committed r156515: <http://trac.webkit.org/changeset/156515>