WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
121963
Weak should have a move constructor and move assignment operator
https://bugs.webkit.org/show_bug.cgi?id=121963
Summary
Weak should have a move constructor and move assignment operator
Anders Carlsson
Reported
2013-09-26 10:08:00 PDT
Weak should have a move constructor and move assignment operator
Attachments
Patch
(4.32 KB, patch)
2013-09-26 10:10 PDT
,
Anders Carlsson
oliver
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2013-09-26 10:10:26 PDT
Created
attachment 212720
[details]
Patch
WebKit Commit Bot
Comment 2
2013-09-26 10:13:02 PDT
Attachment 212720
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSClassRef.cpp', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/heap/Weak.h', u'Source/JavaScriptCore/heap/WeakInlines.h', u'Source/JavaScriptCore/runtime/SimpleTypedArrayController.cpp']" exit_code: 1 Source/JavaScriptCore/heap/Weak.h:60: Missing spaces around && [whitespace/operators] [3] Source/JavaScriptCore/heap/Weak.h:70: Missing spaces around && [whitespace/operators] [3] Source/JavaScriptCore/heap/WeakInlines.h:79: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3
2013-09-26 10:32:49 PDT
Committed
r156469
: <
http://trac.webkit.org/changeset/156469
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug