Bug 121945 - Fix ordered comparison warnings in BitmapImage::drawPattern
Summary: Fix ordered comparison warnings in BitmapImage::drawPattern
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Seokju Kwon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-26 01:53 PDT by Seokju Kwon
Modified: 2013-09-26 09:52 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.40 KB, patch)
2013-09-26 01:56 PDT, Seokju Kwon 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Seokju Kwon 2013-09-26 01:53:51 PDT 
gcc 4.7 warns about the pointer to integer comparison. Debug build breaks on EFL.
WebKit/Source/WebCore/platform/graphics/BitmapImage.cpp:509:9: error: ordered comparison of pointer with integer zero [-Werror=extra]
Comment 1 Seokju Kwon 2013-09-26 01:56:49 PDT 
Created attachment 212676 [details]
Patch
Comment 2 Seokju Kwon 2013-09-26 01:59:05 PDT 
CCing gyuyoung
Comment 3 Darin Adler 2013-09-26 09:25:30 PDT 
Comment on attachment 212676 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212676&action=review

> Source/WebCore/platform/graphics/BitmapImage.cpp:509
> +        ASSERT(buffer.get());

ASSERT(buffer) should work without the get().
Comment 4 WebKit Commit Bot 2013-09-26 09:52:46 PDT 
Comment on attachment 212676 [details]
Patch

Clearing flags on attachment: 212676

Committed r156465: <http://trac.webkit.org/changeset/156465>
Comment 5 WebKit Commit Bot 2013-09-26 09:52:48 PDT 
All reviewed patches have been landed.  Closing bug.