Bug 121939 - [MediaStream API] update MediaStream object to match spec
Summary: [MediaStream API] update MediaStream object to match spec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 124288
  Show dependency treegraph
 
Reported: 2013-09-25 21:59 PDT by Eric Carlson
Modified: 2013-11-13 09:58 PST (History)
10 users (show)

See Also:


Attachments
Patch (8.85 KB, patch)
2013-10-10 13:31 PDT, Thiago de Barros Lacerda
no flags Details | Formatted Diff | Diff
Patch for committing. (14.71 KB, patch)
2013-10-10 16:22 PDT, Thiago de Barros Lacerda
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2013-09-25 21:59:28 PDT
- missing:
    MediaStream  clone ();

- not in spec:
    void stop();	// moved to MediaStreamTrack ?

<rdar://problem/15022373>
Comment 1 Thiago de Barros Lacerda 2013-10-10 13:31:53 PDT
Created attachment 213922 [details]
Patch
Comment 2 Jer Noble 2013-10-10 13:46:09 PDT
Was there no existing test which exercised MediaStream.stop()?
Comment 3 Thiago de Barros Lacerda 2013-10-10 13:51:05 PDT
(In reply to comment #2)
> Was there no existing test which exercised MediaStream.stop()?
I forgot to check that. There is some, I will update them
Comment 4 Jer Noble 2013-10-10 14:18:48 PDT
Comment on attachment 213922 [details]
Patch

In that case, r=me.
Comment 5 Jer Noble 2013-10-10 14:19:50 PDT
(i.e., Just post another patch with the test changes and name it "Patch for committing.")
Comment 6 Thiago de Barros Lacerda 2013-10-10 16:22:29 PDT
Created attachment 213942 [details]
Patch for committing.
Comment 7 WebKit Commit Bot 2013-10-10 16:54:37 PDT
Comment on attachment 213942 [details]
Patch for committing.

Clearing flags on attachment: 213942

Committed r157273: <http://trac.webkit.org/changeset/157273>
Comment 8 WebKit Commit Bot 2013-10-10 16:54:39 PDT
All reviewed patches have been landed.  Closing bug.